Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make TimeSeriesModel extend Serializable #198

Open
Tautvis opened this issue Jun 27, 2017 · 3 comments
Open

Make TimeSeriesModel extend Serializable #198

Tautvis opened this issue Jun 27, 2017 · 3 comments

Comments

@Tautvis
Copy link

Tautvis commented Jun 27, 2017

I'm running Arima models on many time series by mapping TimeSeriesRDD to Arima models. However, ARIMAModel does not extend Serializable and thus can't be stored in RDD. I have to write a wrapper around Arima model like

class SerArimaModel(model: ARIMAModel) 
    extends ARIMAModel(model.p, model.d, model.q, model.coefficients, model.hasIntercept) 
    with Serializable

Wrapper is small but using it tedious. Could TimeSeriesModel be modified to extend Serializable?

@sryza
Copy link
Owner

sryza commented Jul 5, 2017

@Tautvis
Copy link
Author

Tautvis commented Jul 5, 2017

You are right. However, it seems that it wasn't included in latest release (v0.4.1).
Here's the file on the 0.4.1 release TimeSeriesModel.
I'm not sure why this happened as the release was after the change. Do you have any plans releasing 0.4.2?

@sryza
Copy link
Owner

sryza commented Jul 6, 2017

@Tautvis unfortunately that's not something I have bandwidth for in the near future

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants