Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please constrain based on https://bl.syriac.uk/documentation/author-editor-roles.xml #318

Open
davidamichelson opened this issue May 22, 2024 · 11 comments
Assignees

Comments

@davidamichelson
Copy link
Contributor

@wlpotter Should https://syriaca.org/documentation/author-editor-roles.xml be updated to https://bl.syriac.uk/documentation/author-editor-roles.xml?

@davidamichelson
Copy link
Contributor Author

Move for now, but later integrate into Syriaca.org taxonomy

@davidamichelson
Copy link
Contributor Author

davidamichelson commented May 23, 2024

@dlschwartz this will be for msItem/editor/@role

@wlpotter
Copy link
Contributor

Also for /msItem/author/@role -- for attributed, claimed, disputed, etc.

@davidamichelson
Copy link
Contributor Author

@dlschwartz The file is created, so please do constrain the attribute values for msItem/editor/@role and /msItem/author/@role

@wlpotter We have some clean up to do, we have both editor and author with @ROLE translator, also translator is not using an xml:id ref back to this document but it could. Thoughts?

@davidamichelson davidamichelson changed the title Should https://syriaca.org/documentation/author-editor-roles.xml be updated to https://bl.syriac.uk/documentation/author-editor-roles.xml? Please constrain based on https://bl.syriac.uk/documentation/author-editor-roles.xml May 23, 2024
@wlpotter
Copy link
Contributor

The authors with translator role is a mistake I think I made when doing the author and persName normalization. I can switch those back.

They aren't currently pointing to that doc, but we can update them to. I think we were using this as a label for translators in the app so we'll want an issue for changing how those display

@dlschwartz
Copy link
Collaborator

This URL doesn't resolve to HTML. Also, I would like to validate against a GitHub raw file.

@davidamichelson
Copy link
Contributor Author

@dlschwartz
Copy link
Collaborator

@davidamichelson Yesterday we said the following
//tei:msItem/tei:editor/@role = "translator"
//tei:titleStmt/tei:editor/@role = either "creator", "general-editor", "technical-editor"

Do we want to keep any of this?

@wlpotter
Copy link
Contributor

wlpotter commented May 24, 2024

The "creator", "general-editor" and "technical-editor" are all for titleStmt and seriesStmt, so we likely want to allow in the schema. Do we want a schematron rule to further constrain what is allowed in the msItem/editor and msItem/author contexts?

I did notice that we have general and creator in the author-editor-roles.xml file:

@dlschwartz
Copy link
Collaborator

This issue initially suggested I should allow any values in the editors/author site list. I've implemented that for msItem/author/@ROLE. If we further marked up the editors file to indicate certain roles for editors and other roles for authors, I could use that to allow only certain values in certain contexts. Otherwise, I can just hard code the values for the different contexts directly in the ODD without pointing out to the editors file.

@wlpotter
Copy link
Contributor

The values for creator, general, and translator are all sub-categories of the category for "editor", so we could say that there are roles available for authors and editors, which come from: /TEI/teiHeader/encodingDesc/classDecl/taxonomy/category[@xml:id="claimed"]//category/@xml:id (this gives us attributed, disputed, pseudo, etc.).

There are then the editor-specific ones that come from /TEI/teiHeader/encodingDesc/classDecl/taxonomy/category[@xml:id="editor"]//category/@xml:id for general, creator, translator.

This might be worth discussing more though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants