Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Fonts Embedded in All Srophé Apps that use Syriac #268

Open
davidamichelson opened this issue Dec 15, 2023 · 6 comments
Open

Update Fonts Embedded in All Srophé Apps that use Syriac #268

davidamichelson opened this issue Dec 15, 2023 · 6 comments
Assignees
Labels

Comments

@davidamichelson
Copy link
Contributor

davidamichelson commented Dec 15, 2023

UPDATE WITH SOLUTION

@wsalesky Please update the following embedded fonts using fonts found here https://bethmardutho.org/resources/syriacpc/:

Change Estranglo Edessa to Estrangela Talada Revised by J.F. Coakley
Change E. Syriac Adiabene to the new version of E. Syriac Adiabene Revised by J.F. Coakley
Change Serto Batnan to Serto Antioch Bible 2020 Release

This change will affect the BL App, Syriaca.org App, John of Ephesus, Syriac Corpus, GEDSH, BQ Gazetteer, and Caesarea. Thanks!

For some reason, the Syriac text hangs over the left margin (but only when the window is sized a certain way, resizing the window wraps the text differently and makes the margin realign correctly. See picture from

https://bl.vuexistapps.us/browse.html?facet-classfication=Choral%20Books&

Screenshot 2023-12-15 at 2 22 51 PM

@davidamichelson
Copy link
Contributor Author

This appears to be only on mac and perhaps firefox only, so maybe don't worry about it if you can't reproduce it.

@davidamichelson
Copy link
Contributor Author

It must have to do with the line above characters, here is what chrome looks like

Screenshot 2023-12-15 at 2 28 06 PM

@davidamichelson
Copy link
Contributor Author

Leave this until we can discuss.

@davidamichelson davidamichelson changed the title Odd formatting of Syriac margins in browse view Update Fonts Embedded in All Srophé Apps that use Syriac Jan 9, 2024
@davidamichelson
Copy link
Contributor Author

UPDATE WITH SOLUTION

@wsalesky Please update the following embedded fonts using fonts found here https://bethmardutho.org/resources/syriacpc/:

Change Estranglo Edessa to Estrangela Talada Revised by J.F. Coakley
Change E. Syriac Adiabene to the new version of E. Syriac Adiabene Revised by J.F. Coakley
Change Serto Batnan to Serto Antioch Bible 2020 Release

This change will affect the BL App, Syriaca.org App, John of Ephesus, Syriac Corpus, GEDSH, BQ Gazetteer, and Caesarea. Thanks!

wsalesky added a commit to srophe/syriaca that referenced this issue Jan 16, 2024
wsalesky added a commit that referenced this issue Jan 16, 2024
wsalesky added a commit that referenced this issue Jan 16, 2024
@wsalesky
Copy link
Collaborator

@davidamichelson I updated the fonts, but that is not actually the issue. The Syriac font is not marked as Syriac in the text node: https://github.com/srophe/britishLibrary-data/blob/main/data/tei/78.xml#L102C38-L102C38

wsalesky added a commit to srophe/bethqatraye that referenced this issue Jan 17, 2024
wsalesky added a commit to srophe/bethqatraye that referenced this issue Jan 17, 2024
wsalesky added a commit to srophe/e-gedsh-app that referenced this issue Jan 17, 2024
wsalesky added a commit to srophe/e-gedsh-app that referenced this issue Jan 17, 2024
wsalesky added a commit to srophe/spear that referenced this issue Jan 17, 2024
wsalesky added a commit to srophe/syriac-corpus-app that referenced this issue Jan 17, 2024
wsalesky added a commit to srophe/syriac-corpus-app that referenced this issue Jan 17, 2024
@wsalesky
Copy link
Collaborator

Fonts updated to all the apps.

@wsalesky wsalesky assigned davidamichelson and unassigned wsalesky Jan 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants