Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update and hard code the Place Type list for browse and documentation #26

Open
davidamichelson opened this issue Nov 18, 2019 · 4 comments
Open

Update and hard code the Place Type list for browse and documentation #26

davidamichelson opened this issue Nov 18, 2019 · 4 comments
Assignees
@davidamichelson
Milestone
Later

Comments

@davidamichelson
Copy link
Contributor

No description provided.

@davidamichelson davidamichelson self-assigned this Nov 18, 2019
@davidamichelson davidamichelson added this to the Later milestone Dec 17, 2019
@davidamichelson
Copy link
Contributor Author

Find in the app repository and edit http://syriaca.org/documentation/place-types.xml

Please write short descriptions for all new types!

@wlpotter wlpotter mentioned this issue Jan 3, 2020
Closed
@wlpotter
Copy link

wlpotter commented Jan 3, 2020

Need to add 'valley' and 'cemetery'

wlpotter added a commit to srophe/srophe-eXist-app that referenced this issue Jan 3, 2020
@wlpotter
Added cemetery and valley as place-types
2f73da1 
Added new place types used in the BQG, see srophe/bethqatraye#26
@wlpotter
Copy link

wlpotter commented Jan 3, 2020

Added the types to http://syriaca.org/documentation/place-types.xml

see srophe/srophe-eXist-app@2f73da1

@davidamichelson let me know if I need to make any edits; otherwise I think this issue is fixed.

@wlpotter wlpotter assigned davidamichelson and unassigned wlpotter Jan 10, 2020
@wlpotter
Copy link

@davidamichelson we should circle back to this as the changes are not showing up on the HTML page.

I also think we will need to update the BQG documentation here.

Cf. srophe/bethqatraye-data#82 for the schema change request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davidamichelson davidamichelson

Labels
None yet
Projects
None yet
Milestone
Later
Development

No branches or pull requests
2 participants
@davidamichelson @wlpotter