Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace utils.LinkByNameOrAlias with netlink.LinkByName #1908

Merged
merged 7 commits into from
Mar 1, 2024
Merged

Conversation

steiler
Copy link
Collaborator

@steiler steiler commented Feb 22, 2024

The netlink library now supports AltNames/Aliases so we use that feature.

@steiler steiler linked an issue Feb 22, 2024 that may be closed by this pull request
@steiler
Copy link
Collaborator Author

steiler commented Feb 29, 2024

The netlink library has an issue with querying altnames that exceed the 15 char length.
Refere to: vishvananda/netlink#955
This is blocking us from completing this. Hence we need to wait for a fix.

@steiler steiler self-assigned this Feb 29, 2024
@steiler steiler added the enhancement New feature or request label Feb 29, 2024
@steiler steiler marked this pull request as ready for review March 1, 2024 08:36
@steiler steiler requested a review from hellt March 1, 2024 08:36
@hellt
Copy link
Member

hellt commented Mar 1, 2024

This is sweet! Bonus points for making it into netlink 💪

Copy link

codecov bot commented Mar 1, 2024

Codecov Report

Attention: Patch coverage is 71.42857% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 53.33%. Comparing base (5333ca2) to head (1b7d034).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1908      +/-   ##
==========================================
+ Coverage   53.20%   53.33%   +0.13%     
==========================================
  Files         155      154       -1     
  Lines       11303    11262      -41     
==========================================
- Hits         6014     6007       -7     
+ Misses       4437     4402      -35     
- Partials      852      853       +1     
Files Coverage Δ
links/endpoint.go 88.00% <100.00%> (ø)
links/endpoint_bridge.go 60.00% <100.00%> (ø)
links/link.go 63.77% <100.00%> (ø)
links/link_macvlan.go 48.27% <100.00%> (ø)
links/link_mgmt-net.go 58.66% <100.00%> (ø)
links/link_veth.go 80.35% <100.00%> (ø)
links/link_vxlan.go 69.78% <100.00%> (ø)
nodes/bridge/bridge.go 62.90% <100.00%> (ø)
types/types.go 61.53% <ø> (ø)
utils/netlink.go 63.76% <100.00%> (-3.77%) ⬇️
... and 4 more

... and 2 files with indirect coverage changes

@hellt hellt merged commit debcb68 into main Mar 1, 2024
62 checks passed
@hellt hellt deleted the netlinkaltname branch March 1, 2024 09:20
@hellt hellt mentioned this pull request Jul 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Validate LinkByAltName workflow
2 participants