Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove logging args from args given to handlers #730

Closed
wants to merge 1 commit into from
Closed

Remove logging args from args given to handlers #730

wants to merge 1 commit into from

Conversation

m09
Copy link
Contributor

@m09 m09 commented Mar 28, 2019

No description provided.

Copy link
Collaborator

@vmarkovtsev vmarkovtsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is no longer needed using the most recent lookout-sdk-ml version. they are removed automatically.

@m09
Copy link
Contributor Author

m09 commented Mar 28, 2019

ok. Then there must be some problem in setup.py because my version was not updated even though I ran pip install .

@m09
Copy link
Contributor Author

m09 commented Mar 28, 2019

@vmarkovtsev
Copy link
Collaborator

@vmarkovtsev
Copy link
Collaborator

@m09 I bet that Modelforge is not updated on your side because of the version conflict with sourced-ml. This is why we had to hack the CI, and also opened src-d/ml#396

@m09
Copy link
Contributor Author

m09 commented Mar 28, 2019

yup ok, let's close then

@m09 m09 closed this Mar 28, 2019
@m09 m09 deleted the bugfix/unknown-args branch April 3, 2019 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants