Adds warning when one defines a protoLibrary without source sets #2595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinbonnin
approved these changes
Aug 29, 2023
| if (sourceSets.isNotEmpty()) { | ||
| // TODO(Benoit) Probably should be checking for other names than `main`. As well, source | ||
| // sets might be created 'afterEvaluate'. Does that mean we should do this work in | ||
| // `afterEvaluate` as well? See: https://kotlinlang.org/docs/multiplatform-dsl-reference.html#source-sets |
There was a problem hiding this comment.
afterEvaluate {} should be avoided overall. If for any reason "main" is created at a later point, you can use .all {}:
sourceSets.all {
if (name == "main") {
// do stuff
}
}But given this has been like this for a long time, I would say "main" is created when the plugin is applied so it's probably fine.
| // TODO(Benoit) Probably should be checking for other names than `main`. As well, source | ||
| // sets might be created 'afterEvaluate'. Does that mean we should do this work in | ||
| // `afterEvaluate` as well? See: https://kotlinlang.org/docs/multiplatform-dsl-reference.html#source-sets | ||
| if (sourceSets.isNotEmpty() && sourceSets.findByName("main") != null) { |
There was a problem hiding this comment.
Do you need to check isNotEmpty() here?
| sourceSets.getByName("main") { main: SourceSet -> | ||
| main.resources.srcDir(protoOutputDirectory) | ||
| } | ||
| } else { | ||
| project.logger.warn("${project.displayName} doesn't have a 'main' source sets. The .proto files will not automatically be added to the artifact. You have to manually add them.") |
There was a problem hiding this comment.
No need to tell users to add manually if the plugin is not going to be able to consume them afterwards?
Suggested change
| project.logger.warn("${project.displayName} doesn't have a 'main' source sets. The .proto files will not automatically be added to the artifact. You have to manually add them.") | |
| project.logger.warn("${project.displayName} doesn't have a 'main' source sets. The .proto files will not automatically be added to the artifact.") |
oldergod
force-pushed
the
bquenaudon.2023-08-29.warning
branch
from
abed2d7 to
527f584
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we don't find a
resourcessets to add a dependency to, the:jartask or whatever it is will not emit the.protofiles automatically.