From 59489963e2c4e8413e4fcacad734ae4b53209792 Mon Sep 17 00:00:00 2001 From: Nicholas Entin Date: Fri, 19 Jan 2024 21:32:45 -0800 Subject: [PATCH 1/2] Update upload-artifacts action to v4 --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 0051490..7fb7a1a 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -28,7 +28,7 @@ jobs: - name: Build and Test run: Scripts/build.swift xcode ${{ matrix.platform }} `which xcpretty` - name: Upload Results - uses: actions/upload-artifact@v3 + uses: actions/upload-artifact@v4 if: failure() with: name: Test Results From b92b6f3f4c07f44ad4233e35a7f8e69b906979ea Mon Sep 17 00:00:00 2001 From: Nicholas Entin Date: Fri, 19 Jan 2024 21:33:54 -0800 Subject: [PATCH 2/2] [DNM] Force snapshot test to fail --- .../ParalayoutSnapshotTests/ViewAlignmentSnapshotTests.swift | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Example/ParalayoutSnapshotTests/ViewAlignmentSnapshotTests.swift b/Example/ParalayoutSnapshotTests/ViewAlignmentSnapshotTests.swift index e9250ba..83ede68 100644 --- a/Example/ParalayoutSnapshotTests/ViewAlignmentSnapshotTests.swift +++ b/Example/ParalayoutSnapshotTests/ViewAlignmentSnapshotTests.swift @@ -74,7 +74,7 @@ final class ViewAlignmentSnapshotTests: SnapshotTestCase { verifySnapshot(receiverPosition: .center, targetPosition: .topRight) // Test horizontal and vertical offsets. - verifySnapshot(receiverPosition: .center, targetPosition: .topRight, horizontalOffset: 20) + verifySnapshot(receiverPosition: .center, targetPosition: .topRight, horizontalOffset: 0) verifySnapshot(receiverPosition: .center, targetPosition: .topRight, horizontalOffset: -20) verifySnapshot(receiverPosition: .center, targetPosition: .topRight, verticalOffset: 15) verifySnapshot(receiverPosition: .center, targetPosition: .topRight, verticalOffset: -15)