Allow holiday to be set as working day, add second language for holiday name

[jkoinnovatedk]

The feature request

I have two suggestions:

1. A way to mark a holiday as either a working day or non-working day. In Denmark the Labour Day and the Constitution Day is a Holiday (in Danish "Helligdag" (holidays means helligdage), not "Feriedag" (holiday means feridag), but it is still a working day for most people.

2. A way to have a bilingual date table so the developer can choose between English or localized holiday names even though the table is created with e.g. a Danish holiday ruleset.

Proposed solution

Regarding 1., the use of a flag in the template (0 or 1) if the holiday is a non-working day

Regarding 2, a way to add both the English and the localized column in the template

Additional context

No response

[marcosqlbi]

For 1. it is a good idea, but it has to be implemented refreshing the existing metadata. I guess it's easier if we mark the existing holidays as non-working day by default, and we create a special flag to set a holiday that is a working day (assuming the underlying date is a working day).

For 2. we already have translations - do you mean having a second language column regardless of the localization? Again, beside the change to the code, we should consider the implication for the existing configurations.

[jkoinnovatedk]

For 1, thanks, and the easy ways sounds like an excellent solution.

For 2, yeah, two columns were my original suggestion. Maybe it is easier (and better) to have an option in Bravo, where you can select if you want the national holidays in English or your national language.

I have listed the Danish name for the Danish national holidays and commented out the holidays that normally is a working day.

In some companies, the Union has negotiated the working holiday to be a non-working holiday (oh nooo)...

        { "DK", 1, 1, 0, 0, 0, "Nytårsdag", 0, 100, 0, 0 },
        { "DK", 99, -3, 0, 0, 0, "Skærtorsdag", 0, 50, 0, 0 },
        { "DK", 99, -2, 0, 0, 0, "Langfredag", 0, 50, 0, 0 },
	{ "DK", 99, 0, 0, 0, 0, "Påskedag", 0, 50, 0, 0 },
        { "DK", 99, 1, 0, 0, 0, "2. påskedag", 0, 50, 0, 0 },
  //   { "DK", 5, 1, 0, 0, 0, "1. maj", 0, 50, 0, 0 },
        { "DK", 99, 26, 0, 0, 0, "Store bededag", 0, 50, 0, 2023 },   ' Udskift 2023 med 0, hvis du er i Grønland eller på Færøerne
        { "DK", 99, 39, 0, 0, 0, "Kristi himmelfartsdag", 0, 50, 0, 0 },
	{ "DK", 99, 49, 0, 0, 0, "Pinsedag", 0, 50, 0, 0 },
        { "DK", 99, 50, 0, 0, 0, "2. pinsedag", 0, 50, 0, 0 },
   //  { "DK", 6, 5 0, 0, 0, "Grundlovsdag", 0, 50, 0, 0 },   
   //  { "DK", 12, 24, 0, 0, 0, "Juleaften", 0, 50, 0, 0 },
        { "DK", 12, 25, 0, 0, 0, "1. juledag", 0, 100, 0, 0 },
        { "DK", 12, 26, 0, 0, 0, "2. juledag", 0, 100, 0, 0 },
   //  { "DK", 12, 31, 0, 0, 0, "Nytårsaften", 0, 100, 0, 0 },

[jkoinnovatedk]

For 2, may the two columns actually could be an extra option in Bravo, so you can have the logged-in user see the report in either English or your national language but the you of course also need month name and day name as two columns as well (and all other filter columns, like product name, category name etc...,

[marcosqlbi]

Ok I don't promise timing for 1 but it makes sense.

I am really not convinced for 2 because most of the users only choose a single language for everything. I see the point for certain countries, but we should keep a relatively simple configuration for all languages, as we should update all the languages if we introduce a breaking change in configuration files (which also impacts existing deployments). Did you try to customize a template for your specific needs? It could be so much simpler.