chromium_presubmit_config.json5

{
  "disabled_checks": {
    // Checks defined in the //PRESUBMIT.py global scope.
    "PRESUBMIT.py": [
      // We don't use OWNERS files.
      "CheckSecurityOwners",
      // This validates added strings with screenshot tests which we don't use.
      "CheckStrings",
      // We don't update upstream pydeps.
      "CheckPydepsNeedsUpdating",
      // Disable check for .*google.* images being added to the repository.
      "CheckNoProductIconsAddedToPublicRepo",
      // Disable check for Google support URLs.
      "CheckGoogleSupportAnswerUrlOnUpload",
      // Disable check for hardcoded Google API urls.
      "CheckHardcodedGoogleHostsInLowerLayers",
    ],
    // Checks defined in depot_tools/presubmit_canned_checks.py.
    "canned": [
      // Disable Chromium license check. We use our own checker.
      "CheckLicense",
      // We don't use OWNERS files.
      "CheckOwnersFormat",
      "CheckOwners",
      // We don't use AUTHORS file.
      "CheckAuthorizedAuthor",
      // We don't upload change to Chromium version control.
      "CheckChangeWasUploaded",
      "CheckChangeHasBugField",
      "CheckTreeIsOpen",
      // We run our own format check.
      "CheckPatchFormatted",
    ],
  },

  // Checks that should trigger presubmit errors instead of warnings.
  "checks_to_force_presubmit_errors": {
    "PRESUBMIT.py": [
      "CheckBuildConfigMacrosWithoutInclude",
      "CheckForSuperfluousStlIncludesInHeaders",
      "CheckForIncludeGuards",
      "CheckGnGlobForward",
      "CheckNewHeaderWithoutGnChangeOnUpload",
    ],
    "canned": [
      "CheckChangeLintsClean",
      "GetPylint",
    ],
  },

  // Additional files to check (extends InputApi.DEFAULT_FILES_TO_CHECK).
  "additional_default_files_to_check": [
    ".+\\.jsx$",
    ".+\\.tsx$",
  ],

  // Files to skip in all checks.
  "default_files_to_skip": [
    "\\.storybook/",
    "components/brave_wallet/resources/solana_web3_script\\.js",
    "ios/browser/api/brave_rewards/legacy_database/core_data_models/",
    "third_party/rust/",
    "tools/crates/",
    "win_build_output/",
  ],

  // Regex to match function names in the current presubmit stack trace. Matched
  // functions are used in `per_check_files_to_skip` filter.
  "check_function_regex": "_?Check",

  // Files to skip per check.
  "per_check_files_to_skip": {
    // Permanent ignores.
    "CheckNewHeaderWithoutGnChangeOnUpload": ["chromium_src/"],
    "CheckForCcIncludes": ["chromium_src/"],
    "CheckForRelativeIncludes": ["chromium_src/"],
    "CheckParseErrors": [
      ".*tsconfig\\.json",
      "components/brave_ads/core/test/data/invalid\\.json",
    ],
    "CheckNoBannedFunctions": [
      // Use `ban_rule_excluded_paths` instead.
    ],

    // Checks to be fixed.
    "CheckUnwantedDependencies": [".*\\.java"],
    "CheckSpamLogging": [
      "browser/browsing_data/brave_clear_browsing_data\\.cc",
      "chromium_src/chrome/browser/ui/startup/startup_browser_creator\\.cc",
      "components/brave_vpn/winvpntool\\.cc",
      "components/greaselion/browser/greaselion_download_service\\.cc",
      "components/permissions/permission_lifetime_utils\\.cc",
      "components/tor/tor_launcher_factory\\.cc",
      "components/webcompat_reporter/browser/webcompat_report_uploader\\.cc",
      "ios/browser/api/brave_rewards/legacy_database/legacy_ledger_database\\.mm",
      "ios/browser/api/brave_rewards/promotion_solution\\.mm",
    ],
    "CheckUniquePtrOnUpload": [
      "components/brave_sync/qr_code_data\\.cc",
      "components/brave_news/browser/direct_feed_controller\\.cc",
      "components/brave_wallet/browser/tx_service\\.cc",
      "components/brave_wallet/common/eth_sign_typed_data_helper\\.cc",
      "components/tor/tor_profile_service_impl\\.cc",
    ],
    "_CheckAndroidCrLogUsage": [
      "android/java/org/chromium/base/BraveCommandLineInitUtil\\.java",
      "android/java/org/chromium/chrome/browser/BraveAdaptiveCaptchaUtils\\.java",
      "android/java/org/chromium/chrome/browser/crypto_wallet/fragments/EditVisibleAssetsBottomSheetDialogFragment\\.java",
      "android/java/org/chromium/chrome/browser/help/BraveHelpAndFeedbackLauncher\\.java",
      "android/java/org/chromium/chrome/browser/search_engines/settings/BraveSearchEngineAdapter\\.java",
      "android/java/org/chromium/chrome/browser/settings/BravePreferenceDialogFragment\\.java",
      "android/java/org/chromium/chrome/browser/upgrade/BraveUpgradeJobIntentServiceImpl\\.java",
    ],
    "_CheckAndroidToastUsage": [
      "android/java/org/chromium/chrome/browser/brave_news/BraveNewsBottomSheetDialogFragment\\.java",
      "android/java/org/chromium/chrome/browser/crypto_wallet/activities/AccountPrivateKeyActivity\\.java",
      "android/java/org/chromium/chrome/browser/crypto_wallet/activities/NetworkSelectorActivity\\.java",
      "android/java/org/chromium/chrome/browser/crypto_wallet/fragments/PortfolioFragment\\.java",
      "android/java/org/chromium/chrome/browser/crypto_wallet/fragments/onboarding_fragments/BackupWalletFragment\\.java",
      "android/java/org/chromium/chrome/browser/crypto_wallet/fragments/onboarding_fragments/SecurePasswordFragment\\.java",
      "android/java/org/chromium/chrome/browser/crypto_wallet/fragments/onboarding_fragments/UnlockWalletFragment\\.java",
      "android/java/org/chromium/chrome/browser/crypto_wallet/modal/BraveWalletPanel\\.java",
      "android/java/org/chromium/chrome/browser/rate/RateDialogFragment\\.java",
      "android/java/org/chromium/chrome/browser/settings/BraveStatsPreferences\\.java",
      "android/java/org/chromium/chrome/browser/settings/BraveSyncScreensPreference\\.java",
      "android/java/org/chromium/chrome/browser/settings/developer/BraveQAPreferences\\.java",
      "android/java/org/chromium/chrome/browser/util/BraveDbUtil\\.java",
    ],
    "CheckForDeprecatedOSMacros": [
      "browser/ntp_background/custom_background_file_manager\\.h",
      "browser/ntp_background/ntp_custom_background_images_service_delegate\\.cc",
      "browser/ui/webui/new_tab_page/brave_new_tab_page_handler\\.cc",
      "components/brave_sync/network_time_helper\\.cc",
    ],
    "CheckConsistentGrdChanges": [
      "browser/ui/android/strings/android_brave_strings\\.grd",
    ],
    "CheckRawPtrUsage": [
      "components/brave_search/renderer/brave_search_default_js_handler\\.h",
      "components/brave_search/renderer/brave_search_fallback_js_handler\\.h",
      "components/brave_search/renderer/brave_search_service_worker_holder\\.h",
      "components/brave_wallet/renderer/js_ethereum_provider\\.h",
      "components/content_settings/renderer/brave_content_settings_agent_impl_autoplay_browsertest\\.cc",
      "components/cosmetic_filters/renderer/cosmetic_filters_js_handler\\.h",
      "components/speedreader/renderer/speedreader_js_handler\\.h",
    ],
    // A temporary fix to silence a failing presubmit check on file renames.
    "CheckStableMojomChanges": [
      "components/brave_rewards/common/mojom/.*",
      "components/services/bat_ads/public/interfaces/bat_ads\\.mojom",
      "components/services/bat_ledger/public/interfaces/.*",
      "components/services/bat_rewards/public/interfaces/.*",
    ],
    "CheckWebDevStyle": [
      "components/speedreader/resources/speedreader-desktop.css",
      "components/speedreader/resources/third_party/",
      "components/webpack/gen-webpack-grd\\.js",
      "test/data/speedreader/",
    ]
  },

  // Additional excludes to _BANRULE_* lists in //PRESUBMIT.py.
  //
  // Maps BanRule.pattern -> BanRule.excluded_paths.
  "ban_rule_excluded_paths": {
    "import android.annotation.TargetApi;": [
      "android/java/org/chromium/chrome/browser/notifications/BraveNotificationSettingsBridge\\.java",
      "android/java/org/chromium/chrome/browser/qrreader/CameraSource\\.java",
      "browser/notifications/android/java/src/org/chromium/chrome/browser/notifications/BraveNotificationManagerProxyImpl\\.java",
    ],
    "leveldb::DB::Open": [
      "components/brave_shields/browser/https_everywhere_service\\.cc",
    ],
    "/\\s+UTF8String\\s*]": [
      "base/mac/conversions\\.h",
      "browser/mac/sparkle_glue\\.mm",
    ],
    "/\\bstd::bind\\b": [
      "components/brave_rewards/.*",
    ],
    "/\\bstd::function\\b": [
      "chromium_src/chrome/browser/ui/views/frame/browser_non_client_frame_view_factory_views\\.cc",
      "components/brave_rewards/core/.*",
      "ios/browser/api/bookmarks/exporter/brave_bookmarks_exporter\\.mm",
      "ios/browser/api/bookmarks/importer/brave_bookmarks_importer\\.mm",
    ],
    "/\\bstd::shared_ptr\\b": [
      "browser/net/.*",
      "components/brave_rewards/core/.*",
      "ios/browser/api/certificate/brave_certificate\\.mm",
      "ios/browser/api/net/certificate_utility\\.mm",
    ],
    "/\\bstd::sto(f|d|ld)\\b": [
      "browser/ui/webui/brave_rewards_page_ui\\.cc",
      "components/brave_rewards/core/legacy/bat_util\\.cc",
      "components/brave_rewards/core/legacy/media/youtube\\.cc",
    ],
    "/\\bstd::sto(i|l|ul|ll|ull)\\b": [
      "components/brave_rewards/browser/test/rewards_state_browsertest\\.cc",
      "components/brave_rewards/core/legacy/media/github\\.cc",
      "components/brave_rewards/core/report/report\\.cc",
      "components/brave_wallet/browser/rlp_encode_unittest\\.cc",
      "components/brave_wallet/common/eth_address\\.cc",
      "components/ipfs/ipfs_json_parser\\.cc",
      "utility/importer/chrome_importer\\.cc",
    ],
    "/\\busing namespace ": [
      "browser/ui/webui/new_tab_page/brave_new_tab_ui_browsertest\\.cc",
      "browser/ui/webui/private_new_tab_page/brave_private_new_tab_page_browsertest\\.cc",
      "chromium_src/components/search_engines/brave_template_url_prepopulate_data_unittest\\.cc",
      "components/brave_shields/browser/ad_block_engine\\.cc",
    ],
    "/v8::Extension\\(": [
      "components/safe_builtins/renderer/safe_builtins\\.cc",
    ],
    "StringFromGUID2": [
      "chromium_src/chrome/install_static/brave_install_util_unittest\\.cc",
    ],
  },
}