Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default to starting a single process #41

Open
nvllsvm opened this issue Aug 19, 2020 · 2 comments
Open

Default to starting a single process #41

nvllsvm opened this issue Aug 19, 2020 · 2 comments

Comments

@nvllsvm
Copy link
Contributor

nvllsvm commented Aug 19, 2020

What
Start a single process unless explicitly configured to start more.

def start_server(self, port_number, number_of_procs=0):

Current
Virtual-CPU-number of processes are started.
1 process is started when running in debug mode.

Why
It's more consistent when deploying to environments where one is not responsible for provisioning the underlying system (ex. Docker).

@nvllsvm nvllsvm changed the title Always default to a single process Default to starting a single process Aug 19, 2020
@nvllsvm
Copy link
Contributor Author

nvllsvm commented Apr 8, 2022

It's important to use a single process when running a sprockets.http with envconsul. Otherwise, each reload of envconsul will result in lingering child processes.

hashicorp/envconsul#177

@nvllsvm
Copy link
Contributor Author

nvllsvm commented Apr 8, 2022

Just saw that this is a thing: tornadoweb/tornado#2801

I'm now thinking of removing this option entirely from sprockets.http and always using only a single process.

@dave-shawley Thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant