Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate the metric methods in sprockets_statsd.tornado.RequestHandler #12

Open
nvllsvm opened this issue Mar 30, 2022 · 0 comments
Open

Comments

@nvllsvm
Copy link
Contributor

nvllsvm commented Mar 30, 2022

What
Deprecate the following methods of sprockets_statsd.tornado.RequestHandler in favor of the methods provided by self.application.statsd_connector

  • increase_counterincr
  • record_timingtiming
  • execution_timertimer

Why
The RequestHandler specific methods differ slightly from the methods provided by the connector. Specifically, they concatenate method arguments to create the metric path. This can cause confusion when doing something like this:

increase_counter('errors.retries', 5)

One might expect that to increment errors.retries by 5, but it actually increases errors.retries.5 by 1.

Also - these methods are specific only to a Tornado application. I've started using sprockets-statsd in a non-Tornado application and would like consistent method calls across my applications.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant