Upgrade gradle 8.6 #1145

jvalkeal · 2024-03-14T15:36:26Z

No description provided.

- Breaking change in artifactory plugin with gradle 8.x which mean we need to go back to maven publish instead of relying archives configuration. - Relates #1145

jvalkeal · 2024-03-15T08:57:56Z

Reopen as we probably need to revert back to gradle 7.6.x due to weird issues with signing plugin.

This reverts commit 362e5f0. Going back to gradle 7.6.x due to signing issue happening with #1145.

jvalkeal · 2024-03-15T09:11:13Z

Essentially with gradle 8.6 we get:

Note, you need env variables ORG_GRADLE_PROJECT_signingKey and ORG_GRADLE_PROJECT_signingPassword to point to valid credentials for signing attempt to happen.

> Task :spring-statemachine-core:signMavenJavaPublication FAILED

FAILURE: Build failed with an exception.

* What went wrong:
A problem was found with the configuration of task ':spring-statemachine-core:signMavenJavaPublication' (type 'Sign').
  - In plugin 'org.gradle.plugins.signing.SigningPlugin$Inject' type 'org.gradle.plugins.signing.Sign' property 'generatorsByKey./home/jvalkealahti/repos/spring/spring-statemachine/main/spring-statemachine-core/build/classes/java/main.toSign' file '/home/jvalkealahti/repos/spring/spring-statemachine/main/spring-statemachine-core/build/classes/java/main' is not a file.
    
    Reason: Expected an input to be a file but it was a directory.
    
    Possible solutions:
      1. Use a file as an input.
      2. Declare the input as a directory instead.

When looking older gradle versions 8.2 is a first one to show this issue. 8.1 was still ok. Signing logic in buildSrc was copied from spring-security which is using 8.6 without issues meaning it's something else in a statemachine build causing it.

jvalkeal · 2024-03-15T09:16:12Z

When trying to debug behaviour I noticed that modifying:

spring-statemachine/buildSrc/src/main/java/org/springframework/statemachine/gradle/SpringSigningPlugin.java

Lines 63 to 67 in 451f12a

    
           public void execute(PublishAllJavaComponentsPlugin publishingPlugin) { 
        
           	PublishingExtension publishing = project.getExtensions().findByType(PublishingExtension.class); 
        
           	Publication maven = publishing.getPublications().getByName("mavenJava"); 
        
           	signing.sign(maven); 
        
           }

Just by adding call to getPublishableArtifacts() in a DefaultMavenPublication makes this issue go away. Internally it calls DefaultMavenPublication.populateFromComponent() which does something.

public void execute(PublishAllJavaComponentsPlugin publishingPlugin) {
	PublishingExtension publishing = project.getExtensions().findByType(PublishingExtension.class);
	Publication maven = publishing.getPublications().getByName("mavenJava");
	if (maven instanceof DefaultMavenPublication p) {
		PublicationArtifactSet<MavenArtifact> publishableArtifacts = p.getPublishableArtifacts();
	}
	signing.sign(maven);
}

jvalkeal · 2024-03-15T09:19:07Z

This test key was created by gpg --output public.pgp --armor --export [email protected] with password passwordD1

jvalkeal · 2024-03-20T14:47:58Z

Turned out to be this gradle stuff copied from boot

https://github.com/spring-projects/spring-boot/blob/62f922369d2714847f8e0f559e282f62d8eac63d/buildSrc/src/main/java/org/springframework/boot/build/MavenPublishingConventions.java#L117-L126

jvalkeal added this to the 4.0.1 milestone Mar 14, 2024

jvalkeal self-assigned this Mar 14, 2024

jvalkeal closed this as completed in 362e5f0 Mar 14, 2024

jvalkeal added a commit that referenced this issue Mar 14, 2024

Fix publishing

7a81d6b

- Breaking change in artifactory plugin with gradle 8.x which mean we need to go back to maven publish instead of relying archives configuration. - Relates #1145

jvalkeal reopened this Mar 15, 2024

jvalkeal added a commit that referenced this issue Mar 15, 2024

Revert "Upgrade gradle 8.6"

451f12a

This reverts commit 362e5f0. Going back to gradle 7.6.x due to signing issue happening with #1145.

jvalkeal modified the milestones: 4.0.1, 4.0.x Mar 15, 2024

jvalkeal modified the milestones: 4.0.x, 4.0.1 Mar 20, 2024

jvalkeal closed this as completed in 7eda62f Mar 20, 2024

rwinch mentioned this issue May 30, 2024

Upgrade to Gradle 8.7 spring-projects/spring-security-kerberos#208

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade gradle 8.6 #1145

Upgrade gradle 8.6 #1145

jvalkeal commented Mar 14, 2024

jvalkeal commented Mar 15, 2024

jvalkeal commented Mar 15, 2024

jvalkeal commented Mar 15, 2024

jvalkeal commented Mar 15, 2024

jvalkeal commented Mar 20, 2024

Upgrade gradle 8.6 #1145

Upgrade gradle 8.6 #1145

Comments

jvalkeal commented Mar 14, 2024

jvalkeal commented Mar 15, 2024

jvalkeal commented Mar 15, 2024

jvalkeal commented Mar 15, 2024

jvalkeal commented Mar 15, 2024

jvalkeal commented Mar 20, 2024