Streamline UUIDConverter #8766
Merged
Streamline UUIDConverter #8766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tzolov
commented
Oct 16, 2023
tzolov
commented
- Use StandardCharsets.UTF_8 as a charset configuration instead of string. Later remove the necessity of handling encoder errors.
- Use regular expressions to validate the UUID string standard representation. Later obsolete the need for try/catch exceptions.
artembilan
requested changes
Oct 16, 2023
| */ | ||
| public class UUIDConverter implements Converter<Object, UUID> { | ||
|
|
||
| public static final String DEFAULT_CHARSET = "UTF-8"; | ||
| public static final Charset DEFAULT_CHARSET = StandardCharsets.UTF_8; |
There was a problem hiding this comment.
We cannot do this change since it is a public property.
Since it is final and really cannot be changed, I suggest the change like:
- Deprecate this constant: there is really just that
StandardCharsets.UTF_8. This one in this class is just out of use. - Use the mentioned
StandardCharsets.UTF_8in the code below instead of this constant.
|
|
||
| /** | ||
| * Convert the input to a UUID using the convenience method | ||
| * {@link #getUUID(Object)}. | ||
| * Convert the input to a UUID using the convenience method {@link #getUUID(Object)}. | ||
| * |
There was a problem hiding this comment.
Consider to remove blank lines from method Javadocs since we are already here in changes for this class.
| @@ -115,4 +103,14 @@ private static byte[] serialize(Object object) { | |||
| return stream.toByteArray(); | |||
| } | |||
|
|
|||
| /** | |||
| * Verifies if the provided UUID string complies with the standard representation. | |||
There was a problem hiding this comment.
I don't see a reason in Javadocs for private methods, but if you still would like to have it here, please, consider to make it consistent we are rules:
- Imperative (not infinitive) - therefore
Verify. - No blank lines in method Javadocs.
https://github.com/spring-projects/spring-framework/wiki/Code-Style#javadoc-formatting
- Use StandardCharsets.UTF_8 as a charset configuration instead of string. Later remove the necessity of handling encoder errors. - Use regular expressions to validate the UUID string standard representation. Later obsolete the need for try/catch exceptions.
tzolov
force-pushed
the
uuid-validation
branch
from
25d2003 to
e88e79a
Compare
artembilan
reviewed
Oct 16, 2023
spring-integration-core/src/main/java/org/springframework/integration/util/UUIDConverter.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.