Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change pom name from "bom" to "dependencies" #28

Closed
dsyer opened this issue Oct 16, 2024 · 6 comments
Closed

Change pom name from "bom" to "dependencies" #28

dsyer opened this issue Oct 16, 2024 · 6 comments
Labels
good first issue Good for newcomers
Milestone

Comments

@dsyer
Copy link
Collaborator

dsyer commented Oct 16, 2024

We use it to manage io.grpc and io.netty dependencies, so it's not just a bom. This is consistent with the naming of spring-boot-dependencies.

@dsyer dsyer added the good first issue Good for newcomers label Oct 16, 2024
@varunu28
Copy link
Contributor

@dsyer Can I give an attempt on this issue?

@dsyer
Copy link
Collaborator Author

dsyer commented Oct 17, 2024

Of course. No need to ask.

@varunu28
Copy link
Contributor

@dsyer Just to confirm that this task is limited to renaming the pom from bom -> dependencies only & not renaming the complete maven artifact? The artifactId still remains as spring-grpc-bom Correct?

@dsyer
Copy link
Collaborator Author

dsyer commented Oct 19, 2024

Not sure what you mean. The only thing you can change is the artifact id isn’t it? I suppose we also need to rename the directory.

@varunu28
Copy link
Contributor

Thanks for clarifying. I have created #32 to address this issue.

@dsyer
Copy link
Collaborator Author

dsyer commented Oct 21, 2024

Fixed in #32

@dsyer dsyer closed this as completed Oct 21, 2024
@dsyer dsyer added this to the 0.1.0 milestone Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants