From 9766401d56b4ec7821d068142185a03b7b462f1f Mon Sep 17 00:00:00 2001 From: Manuel Reinhard Date: Fri, 8 Nov 2024 17:12:40 +0100 Subject: [PATCH 1/2] Make property private --- src/PaymentPart/Output/AbstractOutput.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/PaymentPart/Output/AbstractOutput.php b/src/PaymentPart/Output/AbstractOutput.php index 778cd38c..4a572866 100644 --- a/src/PaymentPart/Output/AbstractOutput.php +++ b/src/PaymentPart/Output/AbstractOutput.php @@ -14,8 +14,8 @@ abstract class AbstractOutput implements OutputInterface { protected QrBill $qrBill; protected string $language; - protected DisplayOptions $displayOptions; protected string $qrCodeImageFormat; + private DisplayOptions $displayOptions; public function __construct(QrBill $qrBill, string $language) { From 348072c25ff8fd535da465d0750cd9e315366f1a Mon Sep 17 00:00:00 2001 From: Manuel Reinhard Date: Fri, 8 Nov 2024 17:26:43 +0100 Subject: [PATCH 2/2] Cleanups --- src/PaymentPart/Output/FpdfOutput/FpdfOutput.php | 1 - src/PaymentPart/Output/FpdfOutput/FpdfTrait.php | 3 +-- src/PaymentPart/Output/HtmlOutput/HtmlOutput.php | 1 - src/PaymentPart/Output/TcPdfOutput/TcPdfOutput.php | 1 - 4 files changed, 1 insertion(+), 5 deletions(-) diff --git a/src/PaymentPart/Output/FpdfOutput/FpdfOutput.php b/src/PaymentPart/Output/FpdfOutput/FpdfOutput.php index 5779f553..3d2379d8 100644 --- a/src/PaymentPart/Output/FpdfOutput/FpdfOutput.php +++ b/src/PaymentPart/Output/FpdfOutput/FpdfOutput.php @@ -13,7 +13,6 @@ use Sprain\SwissQrBill\PaymentPart\Output\Element\Text; use Sprain\SwissQrBill\PaymentPart\Output\Element\Title; use Sprain\SwissQrBill\PaymentPart\Output\LineStyle; -use Sprain\SwissQrBill\PaymentPart\Output\VerticalSeparatorSymbolPosition; use Sprain\SwissQrBill\PaymentPart\Translation\Translation; use Sprain\SwissQrBill\QrBill; use Sprain\SwissQrBill\QrCode\QrCode; diff --git a/src/PaymentPart/Output/FpdfOutput/FpdfTrait.php b/src/PaymentPart/Output/FpdfOutput/FpdfTrait.php index a622f875..a152f37b 100644 --- a/src/PaymentPart/Output/FpdfOutput/FpdfTrait.php +++ b/src/PaymentPart/Output/FpdfOutput/FpdfTrait.php @@ -3,8 +3,7 @@ namespace Sprain\SwissQrBill\PaymentPart\Output\FpdfOutput; /** - * @internal DO NOT USE IT. Its purpose is only for the Swiss QR Bill library. Name and/or - * signature may change without any notification + * @internal */ trait FpdfTrait { diff --git a/src/PaymentPart/Output/HtmlOutput/HtmlOutput.php b/src/PaymentPart/Output/HtmlOutput/HtmlOutput.php index f5990cf2..56c90f58 100644 --- a/src/PaymentPart/Output/HtmlOutput/HtmlOutput.php +++ b/src/PaymentPart/Output/HtmlOutput/HtmlOutput.php @@ -13,7 +13,6 @@ use Sprain\SwissQrBill\PaymentPart\Output\HtmlOutput\Template\TextElementTemplate; use Sprain\SwissQrBill\PaymentPart\Output\HtmlOutput\Template\PaymentPartTemplate; use Sprain\SwissQrBill\PaymentPart\Output\HtmlOutput\Template\TitleElementTemplate; -use Sprain\SwissQrBill\PaymentPart\Output\VerticalSeparatorSymbolPosition; use Sprain\SwissQrBill\PaymentPart\Translation\Translation; final class HtmlOutput extends AbstractOutput diff --git a/src/PaymentPart/Output/TcPdfOutput/TcPdfOutput.php b/src/PaymentPart/Output/TcPdfOutput/TcPdfOutput.php index f24284ea..ea566142 100644 --- a/src/PaymentPart/Output/TcPdfOutput/TcPdfOutput.php +++ b/src/PaymentPart/Output/TcPdfOutput/TcPdfOutput.php @@ -4,7 +4,6 @@ use setasign\Fpdi\Tcpdf\Fpdi; use Sprain\SwissQrBill\PaymentPart\Output\LineStyle; -use Sprain\SwissQrBill\PaymentPart\Output\VerticalSeparatorSymbolPosition; use Sprain\SwissQrBill\PaymentPart\Output\AbstractOutput; use Sprain\SwissQrBill\PaymentPart\Output\Element\FurtherInformation; use Sprain\SwissQrBill\PaymentPart\Output\Element\OutputElementInterface;