Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeError: <Target> object is not iterable when check_complete(dep) is False #3280

Open
GianlucaFicarelli opened this issue Mar 5, 2024 · 4 comments

Comments

@GianlucaFicarelli
Copy link
Contributor

When a Task is run, and one of the dependencies is not fulfilled, and this dependency has a single Target as output (instead of a list of targets, or a dict of targets), then Luigi fails with:

Traceback (most recent call last):
  File "/usr/local/lib/python3.10/site-packages/luigi/worker.py", line 188, in run
    nonexistent_outputs = [output for output in dep.output() if not output.exists()]
TypeError: 'RemoteTarget' object is not iterable

The failing code is at this line and it seems related to the changes in #3258.

I think that the code should be fixed to handle the case when dep.output() isn't a list of targets.

@winniehell
Copy link

this was was fixed in #3281 but not yet released.

@andresgomezfrr do you have a rough estimate on when the next version will be released?

@andresgomezfrr
Copy link
Contributor

I released a new one: https://github.com/spotify/luigi/releases/tag/3.5.1 @winniehell

@winniehell
Copy link

@andresgomezfrr thank you! ❤️

@dmyersturnbull
Copy link

This is fixed, right? Should this be closed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants