Skip to content
This repository has been archived by the owner on Mar 28, 2022. It is now read-only.

adaptiveOnsets(): N[] array has no purpose #87

Open
dpwe opened this issue May 11, 2016 · 1 comment
Open

adaptiveOnsets(): N[] array has no purpose #87

dpwe opened this issue May 11, 2016 · 1 comment

Comments

@dpwe
Copy link

dpwe commented May 11, 2016

On lines like https://github.com/spotify/echoprint-codegen/blob/master/src/Fingerprint.cxx#L128
I see logic to set N[j] to the threshold at the most recent crossing of the envelope, but I don't see anywhere where N[j] is read back or used. I conclude it's vestigial and should be removed.

@dpwe
Copy link
Author

dpwe commented May 11, 2016

(in fact, if the compiler is any good, it probably has no impact on the object code anyway).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant