Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generated playlists doesn't use the correct paths when --output is specified #2246

Open
jessicah opened this issue Nov 26, 2024 · 0 comments · May be fixed by #2248
Open

Generated playlists doesn't use the correct paths when --output is specified #2246

jessicah opened this issue Nov 26, 2024 · 0 comments · May be fixed by #2248
Labels
Bug Unexpected problem or unintended behavior that needs to be fixed

Comments

@jessicah
Copy link

jessicah commented Nov 26, 2024

System OS

Windows

Python Version

3.10 (CPython)

Install Source

pip / PyPi

Install version / commit hash

4.2.10

Expected Behavior vs Actual Behavior

Expect playlists to use the correct paths to downloaded files, given the save path specified via --output. Instead, playlists uses some other "default" path format.

Essentially, if --output is set, then also automatically set the "m3u_output" option as well.

Steps to reproduce - Ensure to include actual links!

spotdl --m3u "{list}" --output "{album-artist}\{album}\{disc-number}-{track-number}. {title}.{output-ext}" download all-user-saved-albums

Traceback

D:\spotify-downloader\dist\spotdl-4.2.10-win32.exe --format m4a --bitrate disable --user-auth --m3u "{list}" --save-file metadata.spotdl --save-errors errors.txt --print-errors --archive archive.json --max-retries 10 --log-level DEBUG --preload --add-unavailable --yt-dlp-args "--cookies-from-browser firefox" --output "{album-artist}\{album}\{disc-number}-{track-number}.  {title}.{output-ext}" --generate-lrc --threads 1 --overwrite skip download all-user-saved-albums
[15:28:45] DEBUG    MainThread - Downloader settings: {'audio_providers': ['youtube-music'], 'lyrics_providers': ['genius', 'azlyrics', 'musixmatch'], 'genius_token':          downloader.py:130
                    'alXXDbPZtK1m2RrZ8I4k2Hn8Ahsd0Gh_o076HYvcdlBvmc0ULL1H8Z8xRlew5qaG', 'playlist_numbering': False, 'playlist_retain_track_cover': False, 'scan_for_songs':
                    False, 'm3u': '{list}', 'output': '{album-artist}\\{album}\\{disc-number}-{track-number}.  {title}.{output-ext}', 'm3u_output': '#EXTINF:{duration},
                    {artists} - {title}.{output-ext}', 'overwrite': 'skip', 'search_query': None, 'ffmpeg': 'ffmpeg', 'bitrate': 'disable', 'ffmpeg_args': None, 'format':
                    'm4a', 'save_file': 'metadata.spotdl', 'filter_results': True, 'album_type': None, 'threads': 1, 'cookie_file': None, 'restrict': None, 'print_errors':
                    True, 'sponsor_block': False, 'preload': True, 'archive': 'archive.json', 'load_config': True, 'log_level': 'DEBUG', 'simple_tui': False, 'fetch_albums':
                    False, 'id3_separator': '/', 'ytm_data': False, 'add_unavailable': True, 'generate_lrc': True, 'force_update_metadata': False, 'only_verified_results':
                    False, 'sync_without_deleting': False, 'max_filename_length': None, 'yt_dlp_args': '--cookies-from-browser firefox', 'detect_formats': None, 'save_errors':
                    'errors.txt', 'ignore_albums': None, 'proxy': None, 'skip_explicit': False, 'log_format': None, 'redownload': False, 'skip_album_art': False,
                    'create_skip_file': False, 'respect_skip_file': False, 'sync_remove_lrc': False}

Other details

From the debug info, can clearly see the mismatch between the output and m3u-output keys:

'output': '{album-artist}\{album}\{disc-number}-{track-number}.  {title}.{output-ext}',
'm3u_output': '#EXTINF:{duration}, {artists} - {title}.{output-ext}'
@jessicah jessicah added the Bug Unexpected problem or unintended behavior that needs to be fixed label Nov 26, 2024
jessicah added a commit to jessicah/spotify-downloader that referenced this issue Nov 27, 2024
Format is header, then a list of metadata and filepath pairs.

Fixes spotDL#2246.
@jessicah jessicah linked a pull request Nov 27, 2024 that will close this issue
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Unexpected problem or unintended behavior that needs to be fixed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant