Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use @Nullable and friends? #12

Open
Hjdskes opened this issue May 12, 2016 · 2 comments
Open

Use @Nullable and friends? #12

Hjdskes opened this issue May 12, 2016 · 2 comments
Assignees

Comments

@Hjdskes
Copy link
Member

Hjdskes commented May 12, 2016

I believe this will positively impact our code quality, but it will require an inspection of the current code base. Considering there is not that much yet, I think it's worth it on a long term basis. What do you think?

@Balletie
Copy link

Balletie commented May 13, 2016

Also consider using Optional! https://docs.oracle.com/javase/8/docs/api/java/util/Optional.html

There's a Optional#ofNullable method, which returns an empty optional if the given argument is null, and otherwise returns a "filled" Optional.

@Hjdskes
Copy link
Member Author

Hjdskes commented May 13, 2016

When scanning the code, we should also apply final wherever possible.

@Hjdskes Hjdskes self-assigned this May 14, 2016
@Balletie Balletie reopened this Jun 21, 2016
@Hjdskes Hjdskes reopened this Jun 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants