+
-
+
+
+
+
Cached Flag Sets
+
+
+
{{end}}
diff --git a/splitio/producer/initialization.go b/splitio/producer/initialization.go
index f1a865cb..884b4a6d 100644
--- a/splitio/producer/initialization.go
+++ b/splitio/producer/initialization.go
@@ -90,7 +90,7 @@ func Start(logger logging.LoggerInterface, cfg *conf.Main) error {
flagSetsFilter := flagsets.NewFlagSetFilter(cfg.FlagSetsFilter)
// These storages are forwarded to the dashboard, the sdk-telemetry is irrelevant there
- splitStorage, err := observability.NewObservableSplitStorage(redis.NewSplitStorage(redisClient, logger, flagSetsFilter), logger)
+ splitStorage, err := observability.NewObservableSplitStorage(redis.NewSplitStorage(redisClient, logger, flagSetsFilter, int64(redisOptions.ScanCount)), logger)
if err != nil {
return fmt.Errorf("error instantiating observable feature flag storage: %w", err)
}
diff --git a/splitio/producer/util.go b/splitio/producer/util.go
index f7cda7f2..bd151e01 100644
--- a/splitio/producer/util.go
+++ b/splitio/producer/util.go
@@ -30,6 +30,7 @@ import (
const (
impressionsCountPeriodTaskInMemory = 1800 // 30 min
impressionObserverSize = 500
+ ScanCount = 10
)
func parseTLSConfig(opt *conf.Redis) (*tls.Config, error) {
@@ -99,6 +100,7 @@ func parseRedisOptions(cfg *conf.Redis) (*config.RedisConfig, error) {
WriteTimeout: cfg.WriteTimeout,
PoolSize: cfg.PoolSize,
TLSConfig: tlsCfg,
+ ScanCount: ScanCount,
}
if cfg.SentinelReplication {
diff --git a/splitio/proxy/caching/workers_test.go b/splitio/proxy/caching/workers_test.go
index e90ca744..a979c9d9 100644
--- a/splitio/proxy/caching/workers_test.go
+++ b/splitio/proxy/caching/workers_test.go
@@ -289,6 +289,9 @@ func (*splitStorageMock) FetchMany(splitNames []string) map[string]*dtos.SplitDT
func (*splitStorageMock) GetNamesByFlagSets(sets []string) map[string][]string {
panic("unimplemented")
}
+func (*splitStorageMock) GetAllFlagSetNames() []string {
+ panic("unimplemented")
+}
func (*splitStorageMock) KillLocally(splitName string, defaultTreatment string, changeNumber int64) {
panic("unimplemented")
}
@@ -346,28 +349,28 @@ func (*segmentStorageMock) SegmentContainsKey(segmentName string, key string) (b
func (*segmentStorageMock) SegmentKeysCount() int64 { panic("unimplemented") }
/*
-type segmentUpdaterMock struct {
- SynchronizeSegmentCall func(name string, till *int64) (*segment.UpdateResult, error)
- SynchronizeSegmentsCall func() (map[string]segment.UpdateResult, error)
- SegmentNamesCall func() []interface{}
- IsSegmentCachedCall func(segmentName string) bool
-}
+ type segmentUpdaterMock struct {
+ SynchronizeSegmentCall func(name string, till *int64) (*segment.UpdateResult, error)
+ SynchronizeSegmentsCall func() (map[string]segment.UpdateResult, error)
+ SegmentNamesCall func() []interface{}
+ IsSegmentCachedCall func(segmentName string) bool
+ }
-func (s *segmentUpdaterMock) SynchronizeSegment(name string, till *int64) (*segment.UpdateResult, error) {
- return s.SynchronizeSegmentCall(name, till)
-}
+ func (s *segmentUpdaterMock) SynchronizeSegment(name string, till *int64) (*segment.UpdateResult, error) {
+ return s.SynchronizeSegmentCall(name, till)
+ }
-func (s *segmentUpdaterMock) SynchronizeSegments() (map[string]segment.UpdateResult, error) {
- return s.SynchronizeSegmentsCall()
-}
+ func (s *segmentUpdaterMock) SynchronizeSegments() (map[string]segment.UpdateResult, error) {
+ return s.SynchronizeSegmentsCall()
+ }
-func (s *segmentUpdaterMock) SegmentNames() []interface{} {
- return s.SegmentNamesCall()
-}
+ func (s *segmentUpdaterMock) SegmentNames() []interface{} {
+ return s.SegmentNamesCall()
+ }
-func (s *segmentUpdaterMock) IsSegmentCached(segmentName string) bool {
- return s.IsSegmentCachedCall(segmentName)
-}
+ func (s *segmentUpdaterMock) IsSegmentCached(segmentName string) bool {
+ return s.IsSegmentCachedCall(segmentName)
+ }
*/
var _ split.Updater = (*splitUpdaterMock)(nil)
var _ storage.SplitStorage = (*splitStorageMock)(nil)
diff --git a/splitio/proxy/storage/splits.go b/splitio/proxy/storage/splits.go
index 46cfc04d..4214dd52 100644
--- a/splitio/proxy/storage/splits.go
+++ b/splitio/proxy/storage/splits.go
@@ -179,6 +179,13 @@ func (*ProxySplitStorageImpl) GetNamesByFlagSets(sets []string) map[string][]str
return nil
}
+// GetAllFlagSetNames implements storage.SplitStorage
+func (*ProxySplitStorageImpl) GetAllFlagSetNames() []string {
+ // NOTE: This method is NOT used by the proxy.
+ // we need to revisit our interfaces so that we're not obliged to do this smeely empty impls.
+ return nil
+}
+
func (p *ProxySplitStorageImpl) setStartingPoint(cn int64) {
p.mtx.Lock()
// will be executed only the first time this method is called or when
diff --git a/splitio/version.go b/splitio/version.go
index a906b92b..d1d43be0 100644
--- a/splitio/version.go
+++ b/splitio/version.go
@@ -2,4 +2,4 @@
package splitio
// Version is the version of this Agent
-const Version = "5.5.1"
+const Version = "5.6.0"