Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove jQuery dependency #2

Open
Reached opened this issue Oct 19, 2019 · 1 comment
Open

Remove jQuery dependency #2

Reached opened this issue Oct 19, 2019 · 1 comment
Labels
hacktoberfast help wanted Extra attention is needed

Comments

@Reached
Copy link

Reached commented Oct 19, 2019

Looks like a cool package :)

Would you be okay with accepting a PR removing the jQuery dependency? I don't think it's necessary, as Sweet Alert don't depend on it?

Keep up the good work!
@emredipi
Copy link
Member

Thanks for feedback. I am open for PRs but I did not add information about PR or licence to the readme since I am new in open source.
You are absolutely right. The reason why I used JQuery is that, the theme that I use is using JQuery already and this was the easiest way for me.

@emredipi emredipi added the help wanted Extra attention is needed label Sep 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
hacktoberfast help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Reached @emredipi