Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

imcompatible with navigation v3 #6

Open
gotexis opened this issue Dec 5, 2018 · 4 comments
Open

imcompatible with navigation v3 #6

gotexis opened this issue Dec 5, 2018 · 4 comments

Comments

@gotexis
Copy link

gotexis commented Dec 5, 2018

Seems like navigation v3 has introduced some global app-container that must be declared explicitly so it broke the current implementation.

@spencercarli
Copy link
Owner

That's good to know. I haven't used React Navigation v3 yet. Do you have a link to an upgrade guide?

@gotexis
Copy link
Author

gotexis commented Dec 6, 2018

Hey

Looks like there wasnt an official one, but below seems to be pretty detailed.
medium

There's not a lot of breaking changes, but the main problem I found was that there need to be an explicit top-level wrapper imported from React-navigation now so whever used to be RootStack, now needs to be createAppContainer(RootStack). Seems like navigation steps are being stored into that top level container.

But then this confuses me how to set up redux. I think I've then wrapped the createAppContainer in a Store/Provider tag and it seemed to work. Only I hope that the props can propagate correctly, haven't tested.

I am a newcomer to react-native and the fact that React core functions (Redux, redux-saga, react-navigation, and even "Expo") are provided by separate groups of people is giving me aids....

@patricktargun
Copy link

Did anyone come up with a commit for this update?

@dakzh
Copy link

dakzh commented Jan 30, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants