[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: acraghav
To complete the pull request process, please assign abhinavnagaraj
You can assign the PR to them by writing /assign @abhinavnagaraj in a comment when ready.

The full list of commands accepted by this bot can be found here.

Welcome @acraghav! It looks like this is your first PR to spectrocloud/cluster-api-provider-vsphere-static-ip 🎉

Hi @acraghav. Thanks for your PR.

I'm waiting for a spectrocloud member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

@acraghav , thanks for the PR !

There might be a simpler way of deallocating. If the IPClaims have the correct ownerRef, then we should be able to start from the owner and list the descendant IPClaims. Deleting these IPClaims should delete the corresponding IPAddresses. Currently, there seems to be a timing issue with the vsphereCluster ownerRef. Let me fix that and open a PR.

@acraghav , I fixed the owner ref issue. Please try with the latest. Deleting VSphereCluster/VSphereMachine should result in the corresponding IPClaim being garbage collected.
This PR won't work since we don't control the finalizer on CAPV objects. Those objects won't wait for m3 objects to be deleted. For Eg., the VSphereMachine object may be deleted before this reconcileDelete(). Then it will result in a no op.