-
-
Notifications
You must be signed in to change notification settings - Fork 513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop netstandard 2.0 #1441
Comments
I would like you to not drop it if possible. PowerShell 5.1 depends on it. If you want Spectre.Console still work there - it's the only way to preserve it. It's similar to: |
Wouldn't it work in AOT mode in those cases, since you would not be framework dependent while also not having to ship the runtime with each app? |
No. That's not how PowerShell modules calls it. They call directly DLL, so while your app with AOT may work in PowerSheell console, it won't work if you have PowerShell module which calls SpecteConsole methods. And to be honest I am not 100% sure net standard 2.0 will help. I still use net framework 4.7 in https://github.com/EvotecIT/ConsoleMonster as sometimes for whatever reason the dependency hell kicks in and things just don't work. The other project https://github.com/ShaunLawrie/PwshSpectreConsole calls netstandard2.0 directly https://github.com/ShaunLawrie/PwshSpectreConsole/blob/df3a470a6ffe8b10739b6a00b3149e7fca343c58/PwshSpectreConsole/PwshSpectreConsole.psd1#L57C1-L61C93 So this may work for Spectre.Console, but I know that in other cases I have to resort to 4.7.2 in PowerShell 5.1 for it to work, as it starts throwing errors for whatever reason otherwise. So if you can please preserver net standard 2.0, and hopefully it can be brought back for Spectre.Console.ImageSharp, because without it, the projects in PowerShell 5.1 are dead. I know I can't make you to retain 4.7.2 as it was dropped a while ago Net Standard 2.0 is the only thing that keeps PS 5.1 alive, and Microsoft intended to keep it till 2027 at least. Until Microsoft pushes PowerShell 7, as default to Windows, majority of companies will stay on PS 5.1 |
Please upvote 👍 this issue if you are interested in it.
The text was updated successfully, but these errors were encountered: