-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider ditching domain_name? #16
Comments
I'd 👍 this as well for a different reason. |
Thanks for the pointer. When dropping support for ruby < 2.2, dependency on unf will be dropped. Hoping I could make it happen in a couple of months. |
Awesome, great news! |
Hello from the future! It's still in here and its still requiring unf_ext, which currently blocks me from building windows containers in docker (I'll save explaining that nightmare for another time). Could we do this with URI instead? I'm happy to put out the PR if so. |
Bug: sparklemotion/http-cookie#16 Signed-off-by: Sam James <[email protected]>
domain_name transitively pulls in unf which in turn pulls in unf_ext. We've gotten some complaints about this in http.rb:
https://www.reddit.com/r/ruby/comments/4gdv0u/http_the_gem_200_a_fast_elegant_http_client_for/d2gqad6
Is it really necessary, and is the transitive dependency on a native extension worth it?
The text was updated successfully, but these errors were encountered: