Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up when HTTP connection closed. #17

Open
beckyconning opened this issue Sep 12, 2017 · 4 comments
Open

Clean up when HTTP connection closed. #17

beckyconning opened this issue Sep 12, 2017 · 4 comments

Comments

@beckyconning
Copy link
Contributor

Load end may never occur its important to clean up when connection is closed.

@spajak
Copy link
Owner

spajak commented Sep 17, 2017

Could you find the real example when this case happens?

@beckyconning
Copy link
Contributor Author

beckyconning commented Sep 26, 2017

node -e "require('http').createServer().listen(8080)"

http connections being left open for a long time is a typical feature. it is commonly found in report generation. http connections being left open indefinitely could happen either purposefully or accidentally on pretty much any web server.

@beckyconning
Copy link
Contributor Author

beckyconning commented Sep 26, 2017

E.g.

cef-pdf --server &
node -e "require('http').createServer().listen(8080)" &
curl -X POST http://localhost:9288/_.pdf --header "Content-Location: http://localhost:8080"

the curl request will never finish and when i close it the cef-pdf process which was spawned continues forever. after a duration the entire cef-pdf http server crashes with a segmentation fault.

@beckyconning
Copy link
Contributor Author

beckyconning commented Sep 26, 2017

to act as a resilient http service cef-pdf must keep its connections as a client and as a server alive, must clean up allocated resources on a connection by connection basis as these connections are closed and must not crash.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants