Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

step skipping oddities #208

Open
stscieisenhamer opened this issue Jun 1, 2017 · 3 comments
Open

step skipping oddities #208

stscieisenhamer opened this issue Jun 1, 2017 · 3 comments
Labels
bug Something isn't working question Further information is requested stpipe

Comments

@stscieisenhamer
Copy link
Collaborator

stscieisenhamer commented Jun 1, 2017

Skipping a step currently does not completely skip a step. The following actions still occur, though there does not seem any clear reason why they should. Basically all actions that would occur surrounding step execution still occur, regardless of whether the step itself is executed.

Unless otherwise indicated, will consider making step skipping a bit more inclusive to not include the above operations.

@stscieisenhamer stscieisenhamer added bug Something isn't working question Further information is requested stpipe labels Jun 1, 2017
@melanieclarke
Copy link
Collaborator

@braingram - I know you were working on step skipping consistency recently (#195). Do you know if any of these issues with skipping steps are still relevant?

@braingram
Copy link
Collaborator

I believe the unresolved issues are still unresolved (but would have to dig in to confirm) so for a skipped step:

  • pre/post hooks still are executed
  • Meta information is updated. In particular CRDS context and version, and software version and commit version.
  • Argument checking. Checking args on something not done?

@melanieclarke
Copy link
Collaborator

Okay, thank you. Can we transfer this ticket to stpipe, then?

@braingram braingram transferred this issue from spacetelescope/jwst Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working question Further information is requested stpipe
Projects
None yet
Development

No branches or pull requests

3 participants