Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Datamodel.open_asdf #299

Open
braingram opened this issue Apr 9, 2024 · 1 comment
Open

Remove Datamodel.open_asdf #299

braingram opened this issue Apr 9, 2024 · 1 comment

Comments

@braingram
Copy link
Collaborator

This method:

def open_asdf(init=None,
ignore_version_mismatch=True,
ignore_unrecognized_tag=False,
**kwargs):

duplicates (identical) options to asdf.open (which also uses ignore_version_mismatch=True and ignore_unrecognized_tag=False and is unused outside of the Datamodel class.

@braingram
Copy link
Collaborator Author

This is a bit more complicated than expected due to the selective keyword argument handling in open_asdf. The method does not pass kwargs to AsdfFile (but does to asdf.open) so several uses in stdatamodels (none in jwst) silently ignore things in kwargs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant