Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update aperture names #426

Closed
schlafly opened this issue May 31, 2024 · 2 comments · Fixed by #498
Closed

Update aperture names #426

schlafly opened this issue May 31, 2024 · 2 comments · Fixed by #498
Assignees

Comments

@schlafly
Copy link
Collaborator

Presently the aperture names in RAD are an enum with allowed values like WFI_01_FULL. This doesn't match the SIAF, where the names are WFI01_FULL. At some point this did match the SIAF, but the SIAF was updated to use the normal WFI detector names. We should probably remain in sync with the SIAF.

https://github.com/spacetelescope/pysiaf/blob/main/pysiaf/prd_data/Roman/roman_siaf.xml#L13
https://github.com/spacetelescope/rad/blob/main/src/rad/resources/schemas/aperture-1.0.0.yaml#L15-L21

My suggestion would be to extend the enum to cover both the old and new names, and then to retire the old names in a ~year, just to avoid causing the files that are currently around to all start breaking.

@PaulHuwe PaulHuwe self-assigned this Oct 6, 2024
@stscijgbot-rstdms
Copy link
Collaborator

This issue is tracked on JIRA as RAD-177.

@stscijgbot-rstdms
Copy link
Collaborator

Comment by Paul Huwe on JIRA:

This is implemented in RAD PR-498:
#498

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants