You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Presently the aperture names in RAD are an enum with allowed values like WFI_01_FULL. This doesn't match the SIAF, where the names are WFI01_FULL. At some point this did match the SIAF, but the SIAF was updated to use the normal WFI detector names. We should probably remain in sync with the SIAF.
My suggestion would be to extend the enum to cover both the old and new names, and then to retire the old names in a ~year, just to avoid causing the files that are currently around to all start breaking.
The text was updated successfully, but these errors were encountered:
Presently the aperture names in RAD are an enum with allowed values like WFI_01_FULL. This doesn't match the SIAF, where the names are WFI01_FULL. At some point this did match the SIAF, but the SIAF was updated to use the normal WFI detector names. We should probably remain in sync with the SIAF.
https://github.com/spacetelescope/pysiaf/blob/main/pysiaf/prd_data/Roman/roman_siaf.xml#L13
https://github.com/spacetelescope/rad/blob/main/src/rad/resources/schemas/aperture-1.0.0.yaml#L15-L21
My suggestion would be to extend the enum to cover both the old and new names, and then to retire the old names in a ~year, just to avoid causing the files that are currently around to all start breaking.
The text was updated successfully, but these errors were encountered: