Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor use of the product datamode in GWCSDrizzle #7296

Closed
stscijgbot-jp opened this issue Oct 17, 2022 · 5 comments
Closed

Refactor use of the product datamode in GWCSDrizzle #7296

stscijgbot-jp opened this issue Oct 17, 2022 · 5 comments

Comments

@stscijgbot-jp
Copy link
Collaborator

Issue JP-2973 was created on JIRA by Jonathan Eisenhamer:

The API of GWCSDrizzle could use with a bit of a refactor. The product DataModel could be better integrated, started in PR#⁠7295, handling the rest of the data arrays in similar fashion.

There is also redundant initialization to None for many of the internal arrays.

Finally, the final output of GWCSDrizzle is unclear. It is in the input product itself. This may be just a documentation issue, though one may consider a method/property that explicitly queries for the result.

@stscijgbot-jp
Copy link
Collaborator Author

Comment by David Law on JIRA:

Jonathan Eisenhamer More long term technical debt?

@stscijgbot-jp
Copy link
Collaborator Author

Comment by Jonathan Eisenhamer on JIRA:

yep, including any issues with this question. may actually consider putting a "debt" label on issues like this. ultimately up to project leads for this type of work. busy work for interns if needed?

@stscijgbot-jp
Copy link
Collaborator Author

Comment by David Law on JIRA:

I was thinking some kind of more accurate label might be helpful.  I've been using 'Trivial' for technical debt, but not only is that not an obvious use, it's at times patently untrue.  Will discuss.

@stscijgbot-jp
Copy link
Collaborator Author

Comment by Nadia Dencheva on JIRA:

The interface to the drizzle C code was refactored and this will be reflected in jwst.resample.GWCSDrizzle.

#8866

@stscijgbot-jp
Copy link
Collaborator Author

Comment by Nadia Dencheva on JIRA:

The drizzle I/O and "Drizzle" class API was refactored and streamlined:

spacetelescope/drizzle#134

The corresponding PR in the JWST pipeline is:

#8866

 

 

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant