You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Clare update: i think it might still be worth some additional coverage to make sure the plots are actually generated, and that unit conversion produces plots in the correct units, even if we are replacing with photutils; my suggestion to archive JDAT-4962 was if you added test coverage in jdaviz after replacing the code with photutils
The text was updated successfully, but these errors were encountered:
Issue JDAT-4966 was created on JIRA by Pey-Lian Lim:
https://photutils.readthedocs.io/en/stable/user_guide/profiles.html
Might make it easier to test and less code to maintain. Have to bump minversion of photutils to at least 1.7.
This also renders JDAT-4962 unnecessary because photutils tests them at https://github.com/astropy/photutils/tree/main/photutils/profiles/tests
Clare update: i think it might still be worth some additional coverage to make sure the plots are actually generated, and that unit conversion produces plots in the correct units, even if we are replacing with photutils; my suggestion to archive JDAT-4962 was if you added test coverage in jdaviz after replacing the code with photutils
The text was updated successfully, but these errors were encountered: