Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aperture Photometry: Use photutils to calculate curve of growth and radial profile #3315

Open
stscijirahubjdat opened this issue Nov 24, 2024 · 0 comments

Comments

@stscijirahubjdat
Copy link

stscijirahubjdat commented Nov 24, 2024

Issue JDAT-4966 was created on JIRA by Pey-Lian Lim:

https://photutils.readthedocs.io/en/stable/user_guide/profiles.html

Might make it easier to test and less code to maintain. Have to bump minversion of photutils to at least 1.7.

This also renders JDAT-4962 unnecessary because photutils tests them at https://github.com/astropy/photutils/tree/main/photutils/profiles/tests

Clare update: i think it might still be worth some additional coverage to make sure the plots are actually generated, and that unit conversion produces plots in the correct units, even if we are replacing with photutils; my suggestion to archive JDAT-4962 was if you added test coverage in jdaviz after replacing the code with photutils

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant