Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Always indicate spectral subregions for the spectrum-at-spaxel tool #3294

Open
james-trayford opened this issue Nov 15, 2024 · 2 comments
Labels
feature Feature request needs-triage Issue opened via template and needs triaging

Comments

@james-trayford
Copy link

james-trayford commented Nov 15, 2024

Jdaviz component

Cubeviz

What is the problem this feature will solve?

When selecting a spectral region it can be useful to keep track of how the spectra may change spaxel-to-spaxel in that region. From what I understand these are indicated on the integrated spectrum and also at the y=0 line in the spectrum viewer, but where the y=0 line and the integrated spectrum fluxes lie outside the spaxel spectrum's y-axis range (usually below and above the range, respectively), this indication is lost.

Describe the desired outcome

I think either having:

  • the region indicated as a coloured segment on the spectrum viewer x axis rather than the y=0 line
  • some low alpha version of the spectral regions designated colour that always shades the plot region between the subselection's wavelength bounds
  • Add spectral selection colouring to the spectrum-at-spaxel line - though this is currently red so may clash. It does have a different thickness than the integrated spectrum though, so if changed to black, the selected segments could be coloured in the same way as the integrated spectrum

Additional context

No response

@james-trayford james-trayford added feature Feature request needs-triage Issue opened via template and needs triaging labels Nov 15, 2024
@camipacifici
Copy link
Contributor

Good point! Thank you.
Adding it to the list.

Thinking ahead, if we treat the sonified cubes as data items, we will not need to use the spectrum at spaxel tool anymore. But we might want to still visualize the individual spectra. What do you think?

@james-trayford james-trayford changed the title [FEAT] Always indicate spectral subregions for the spectrum-at-apaxel tool [FEAT] Always indicate spectral subregions for the spectrum-at-spaxel tool Nov 15, 2024
@james-trayford
Copy link
Author

Yes, true. I think having these as independent data items would be great - I suppose if you want to see the spectrum change with the sound you can turn on the SaS tool. As this is working with spectral regions now it should be easier to make it totally independent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Feature request needs-triage Issue opened via template and needs triaging
Projects
None yet
Development

No branches or pull requests

2 participants