Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use astropy pixel_to_pixel instead of internal calc_pixmap function #51

Open
jdavies-st opened this issue Feb 26, 2020 · 2 comments · May be fixed by #161
Open

Use astropy pixel_to_pixel instead of internal calc_pixmap function #51

jdavies-st opened this issue Feb 26, 2020 · 2 comments · May be fixed by #161
Assignees

Comments

@jdavies-st
Copy link
Collaborator

jdavies-st commented Feb 26, 2020

Use astropy.wcs.utils.pixel_to_pixel instead of

def calc_pixmap(first_wcs, second_wcs):

if possible.

This will require bumping up the astropy and other dependency versions.

@mcara mcara self-assigned this Jun 23, 2023
@mcara mcara added the invalid label Oct 24, 2024
@mcara
Copy link
Member

mcara commented Oct 24, 2024

Not sure what this is referring to but, with a soon to be released 2.0, this issue is no longer valid: the caller can use any method to create a pixel map.

@mcara mcara closed this as completed Oct 24, 2024
@jdavies-st
Copy link
Collaborator Author

This issue is still valid. The calc_pixmap() function maintained here in Drizzle is a specialized version of the more general function in astropy

https://github.com/astropy/astropy/blob/92cf1d46dc165fc3e07fba373a7211b814560fbb/astropy/wcs/utils.py#L887

The functionality has moved upstream to Astropy and therefore Drizzle should use it.

@mcara mcara linked a pull request Oct 25, 2024 that will close this issue
@mcara mcara reopened this Oct 25, 2024
@mcara mcara added enhancement and removed invalid labels Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants