Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Specify proper kdfparams.hash #98

Open
brusherru opened this issue Nov 16, 2023 · 0 comments
Open

Specify proper kdfparams.hash #98

brusherru opened this issue Nov 16, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@brusherru
Copy link
Member

Smcli specifies the wrong crypto.kdfparams.hash property (SHA-256):
https://github.com/spacemeshos/smcli/blob/develop/wallet/store.go#L237

While it uses SHA-512:
https://github.com/spacemeshos/smcli/blob/develop/wallet/store.go#L142
@brusherru brusherru added the bug Something isn't working label Nov 16, 2023
@brusherru brusherru changed the title Proper kdfparams.hash Specify proper kdfparams.hash Nov 16, 2023
@brusherru brusherru mentioned this issue Nov 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@brusherru