-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split poet into registration and worker services #364
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poszu
force-pushed
the
355-registration-svc
branch
2 times, most recently
from
August 31, 2023 14:57
11fef9f
to
9a4e41c
Compare
Codecov Report
@@ Coverage Diff @@
## develop #364 +/- ##
=========================================
- Coverage 73.7% 73.6% -0.1%
=========================================
Files 19 23 +4
Lines 1833 1954 +121
=========================================
+ Hits 1351 1439 +88
- Misses 358 388 +30
- Partials 124 127 +3
|
poszu
force-pushed
the
355-registration-svc
branch
from
August 31, 2023 15:27
9a4e41c
to
ca1be92
Compare
poszu
force-pushed
the
355-registration-svc
branch
from
September 5, 2023 14:53
eddd78a
to
e1dced6
Compare
poszu
force-pushed
the
355-registration-svc
branch
from
September 7, 2023 10:45
5f289a8
to
5b4f1ac
Compare
poszu
force-pushed
the
355-registration-svc
branch
from
September 7, 2023 11:09
75e7413
to
5f5e624
Compare
fasmat
reviewed
Sep 8, 2023
Co-authored-by: Matthias Fasching <[email protected]>
Co-authored-by: Matthias Fasching <[email protected]>
poszu
force-pushed
the
355-registration-svc
branch
from
September 11, 2023 09:14
fe8fd51
to
949b764
Compare
fasmat
reviewed
Sep 11, 2023
Co-authored-by: Matthias Fasching <[email protected]>
fasmat
approved these changes
Sep 12, 2023
poszu
force-pushed
the
355-registration-svc
branch
from
September 12, 2023 18:30
408b817
to
a51fb04
Compare
poszu
force-pushed
the
355-registration-svc
branch
from
September 12, 2023 19:18
a51fb04
to
5d92ff8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #355
Closes #373
Closes #380
Refactored
Service
by splitting it into 2 entities:Registration
Worker
(still namedService
in the code)And two interfaces that they communicate with:
WorkerService
RegistrationService
Registration
It's the front-end service that the node talks to. It is responsible for:
When a time comes, it atomically closes the open round, builds a membership tree, and opens a new round. The root of the membership tree is passed to the worker service via the
WorkerService
interface.Registration
asynchronously waits for proofs coming from theWorker
and stores them in the DB.Worker
It's the backend responsible for executing rounds scheduled by
Registration
. It registers at theRegistrationService
interface for closed rounds and listens for rounds to execute on the returned channel. When a round is finished, it passes the proof back to theRegistrationService
.inMemory
transportIt's an entity implementing both
WorkerService
andRegistrationService
to connect theRegistration
with theWorker
. It's very simple and uses 2 channels to pass data between them.