-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Recovering lost parked nodes #344
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noamnelke
approved these changes
Aug 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
poszu
force-pushed
the
recover-parked-nodes
branch
from
August 16, 2023 07:30
7eebb7d
to
81adefd
Compare
Codecov Report
@@ Coverage Diff @@
## develop #344 +/- ##
=========================================
- Coverage 73.1% 72.8% -0.3%
=========================================
Files 17 17
Lines 1568 1641 +73
=========================================
+ Hits 1147 1196 +49
- Misses 318 334 +16
- Partials 103 111 +8
|
fasmat
reviewed
Aug 16, 2023
noamnelke
approved these changes
Aug 16, 2023
fasmat
approved these changes
Aug 16, 2023
poszu
force-pushed
the
recover-parked-nodes
branch
from
August 16, 2023 12:32
3bf52bc
to
3123490
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recover parked nodes and the top layer of the tree from the layercache.bin files saved on disk instead from the round's state.bin.
Parked nodes recovery
Parked nodes on disk-cached layers are recovered from the files (representing the tree's bottom layers). If a layer contains an odd number of nodes/leafs, the last one is a parked node.
Parked nodes on mem-cached layers are recovered by rebuilding a subtree, in which the bottom layer is built from the nodes in the top disk-cached layer.
mem-cached nodes recovery
The top of the tree that is not persisted on disk is rebuilt as the aforementioned subtree. It's layers from 1 to the root are moved into the recovered tree.
TODO: