diff --git a/src/en/maintainer-meetings/maintainer-meeting-2023-01-07.md b/src/en/maintainer-meetings/maintainer-meeting-2023-01-07.md new file mode 100644 index 000000000..1664b2ac7 --- /dev/null +++ b/src/en/maintainer-meetings/maintainer-meeting-2023-01-07.md @@ -0,0 +1,165 @@ +# Maintainer Meeting (07 January 2023) +```admonish info +Any decisions taken in these notes may no longer be applicable. +``` + +**Time:** 07 January 2023 19:00 UTC + +**Attendees:** +- Moony +- Visne +- ElectroSR +- Remie +- Flipp +- ShadowCommander +- DrSmugleaf +- Vera +- PJB + +## Using source generators for (de)serialization | DrSmugleaf +- Expression trees were a mistake +- **sounds good** + + +## Enforce AccessAttribute and better documentation on new PRs | metalgearsloth +- [Discord link](https://discord.com/channels/310555209753690112/900426319433728030/1060739900758044792) +- **yes** +- may not work for shared components +- check if it works with implementations of the whitelisted type for shared systems + - If it doesn't, make [Access] take an optional list of strings for types in server/client +- ping Vera if something goes terribly wrong + + +## Minify meta.json files | metalgearsloth +- [Discord link](https://discord.com/channels/310555209753690112/900426319433728030/1060432256092618753) +- [GitHub PR](https://github.com/space-wizards/space-station-14/pull/13035) +- Do we minify them + - **no** +- If not change the editorconfig to match the current style (2 space indents) + - **yes** +- Apparently some people copypaste existing meta.jsons to create new ones, which has caused many errors in multiple RSIs +- Reasons not to: + - harder to edit + - harder to review + - ? +- Reasons to: + - there's editor plugins that minify and unminify automatically for you + - this isnt a reason + - ~~saves 1.5 MB~~ not important? it's compressed when game is packaged, etc + - ? + + +## Require all public fields and methods to include xmldoc comments | moony +- [Discord link](https://discord.com/channels/310555209753690112/900426319433728030/1055341182248558623) +- Make sure every method is documented +- Document every field +- **Put this in the PR guidelines** +- https://docs.spacestation14.io/en/getting-started/pr-guideline + + +## Rename entityquery to componentquery | metalgearsloth +- [Discord link](https://discord.com/channels/310555209753690112/900426319433728030/1030122281462136862) +- **Yes** +- Wait for archetypes to rename them + + +## Should Helpers and Extensions be moved to EntitySystems | ShadowCommander +- [Discord link](https://discord.com/channels/310555209753690112/900426319433728030/1018323213517856838) +- **Yes, if it refers to any manager, system or entity** +- **If it's a random helper to save code it doesn't need to be** + + +## Resolve pattern | DrSmugleaf +- **Add call site to arguments of resolve with the new .NET 6 arguments so it can log the file and line if a warning happens.** + + +## Turn IPlayerSession into an entity | moony +- [Discord link](https://discord.com/channels/310555209753690112/900426319433728030/1015187820752683021) +- **Yes** +- This would let us modularize the entire thing and allow us to use events on players directly, letting us get rid of many player-indexed dicts in favor of storing it on the player +- Should this be done at an engine level, or at a content level? +- **Engine** +- **Keep player session, then have an entity field on the session for its data** +- **Mind would still be separate since player session is transient** +- **You can have multiple minds for the lifetime of a single player session** + + +## Replace BUI state handling with normal component state handling for BUI prediction | ElectroSR +- [Discord link](https://discord.com/channels/310555209753690112/900426319433728030/1012164293816483870) +- Laggy interfaces suck +- Everyone is actively avoiding BUI atm +- **Prefer component states to BUI states** +- **Someone refactor BUI please** +- **Have the client manage the UI, the server needs to know if its open** + + +## Component references | PJB +- **Try to remove them** +- How do we have client-only or server-only data on a component without it +- Use different components for that data? + + +## Archetypes | DrSmugleaf +- B O N U S T O P I C +- Need to be made faster before we implement them outside of Robust.Benchmarks +- Do archetype chunking to optimize for CPU cache hits +- Check startup time specially for the JIT when creating all the archetypes +- [Flecs benchmarks](https://github.com/SanderMertens/ecs_benchmark) + + +## Early Access Roadmap +- gamemodes/antags + - dynamic | mirror + - lings? + - needs DNA + - blob | Remie + - revolutionaries + - we want a generic antag overlay system + - loyalty implant + - faction system +- EL BODY SYSTEM | mirror ![](https://cdn.discordapp.com/emojis/933790288860815380.webp =40x) + - some refactors were done by mirror, still some left + - surgery died in the war of 1992 + - Mirror died in the war of 1993 + - limb damage..... +- Salvage proc gen | moony + - she did it go port it https://github.com/Citadel-Station-13/space-station-14/tree/master/Content.Server/_Citadel/Worldgen +- body system but again +- body system +- __***ENGINE EDITOR***__ | PJB + - could benefit from full state reload +- movement refactor + - Client side movement? + - a smidgen + - as a treat + - acruid pls com bak +- Tutorial + - In game + - we have a pr open +- combat rework (needs to be bikeshedded) + - https://github.com/space-wizards/space-station-14/issues/3378 +- ghostrole/antag bans + - unify ghost roles prototype (mind refactor) +- experimental science + - "Science is still a piece of shit" - Vera 28/05/2022 + - "I haven't played the game in 2 years" - Vera 07/01/2023 +- any% maintainer | Jezithyr + - Stuck in canada + - soon tm +- State mandated Xonotic matches | PJB + - Please I have severe withdrawal symptoms + - Replaced by private SS14 playtests + - Woman down +- The game runs like shit how do people play this + - still does | PJB 28/05/2022 + - "how do people play this game" (high pitched scream) | PJB 28/05/2022 + - Slightly better | PJB 11/06/2022 + - It's better but still not as good as I'd like it to be | PJB 25/06/2022 + - I haven't played the game since | PJB 16/07/2022 + - "Please read the last line of that subsection" | PJB 30/07/2022 + - "Please unread the last line of the previous subsection" | PJB 07/01/2023 +- A trailer for Steam + +Crashes / Critical bugs: (when are we moving these to GitHub) +- role timers not counting properly + => till next time diff --git a/src/en/maintainer-meetings/maintainer-meeting-2023-01-21.md b/src/en/maintainer-meetings/maintainer-meeting-2023-01-21.md new file mode 100644 index 000000000..9b57350df --- /dev/null +++ b/src/en/maintainer-meetings/maintainer-meeting-2023-01-21.md @@ -0,0 +1,161 @@ +# Maintainer Meeting (21 January 2023) +```admonish info +Any decisions taken in these notes may no longer be applicable. +``` + +**Time:** 21 January 2023 19:00 UTC + +**Attendees:** +- moony +- AJCM +- Zoldorf +- Visne +- ElectroSR +- Remie +- Wrexbe +- DrSmugleaf +- Vera +- mirrorcult +- PJB + +## Bumping map count to 15 | metalgearsloth +- Most of [c#10595](https://github.com/space-wizards/space-station-14/issues/10595) is done +- 15 is too many +- **Bump it up to 12** +- **1 more low pop map, 1 more high pop map** + +## What to do about RSI licensing | metalgearsloth +- Do we use RGA outside of the folder + - No, RGAs are for other resources +- Do we use something else entirely +- **Make the license field a list of licenses interpreted by a script** +- **Copyright is freeform interpreted by a human** +- **Don't use RGAs for RSIs** + +## Do we explicitly block Windows 7 | PJB +- **Make the pop-up always show up, not only once** +- **Change the text and make closing the pop-up close the launcher too** +- **Localize the pop-up message to Russian if the OS is in Russian** + +## Do we mandate guidebook entries for new large features | mirrorcult +- **Yes** + +## How do we distribute replay recordings & clients, and should we hide some data | ElectroSR +- Should we hide data such as admin aghost positions? + - No +- How do we distribute it + - Tie replays to a version (game/engine), metadata and a link + - Download the replay and its data should launch the sandboxed client with a specific version + - Include the commit number in the replay file (any data can be appended to the replay file from content) + - Content versioning scheme (commit number), download link (if it doesn't work you download it yourself) + +## Can we do another stress test trace | mirrorcult +- Try and say that 10 times fast "stress test trace" + - Stresst +- Run it from time to time (ping PJB) +- Ping tester for it +- Having links that connect you to a server would be useful + +## PJB's renderer ASMR for Jez | PJB +- Problems with the renderer: +- We can't do what Byond can with planes, complex filtering +- We don't want planes (they are a bad idea) +- The alternative is a GOOD API (difficult) +- We can't have multiple post-shaders +- The hard part of a renderer is integrating it into the rest of the game engine (we are 2D) +- There are no existing rendering APIs we can just take +- We need a rendering API to: + - Draw textures, polygons at locations +- The game's code: + - Puts sprites at locations + - People do funny things (shaders, render targets) +- Our API has some of this but is unperformant, not very flexible +- Going from "draw sprite" to "opengl arrays" is just a lot of glue-code, not complicated +- Clyde is divided internally, only one file takes the sprites and actually draws them with the rest of the API +- Using a different rendering API to replace Clyde because of the maintenance burden requires it doing everything that Clyde already does +- We can't build Clyde on top of another incomplete rendering API because it would be spaghetti +- When we tried to use Godot we had our own sprite component and tried to build it on top + - Godot was too high level, too unperformant to integrate with nicely + - Need something that's lower level + - Godot 4 nonwithstanding +- Maybe something like Monogame but we would need a lot of glue code (replacing all of Clyde and refactoring anything that uses Clyde) +- PJB transferred from the Clyde mines and into the Monogame mines (we would need to fork it) +- Any other libraries unknown that don't need us to half-ass it +- Not worth the complexity +- PART 2: Even if you can find a good rendering API +- There are some good libraries (e.g. BGFX) that make you not need to write separate OpenGL/DirectX/Vulkan backends +- You would still have your own "Clyde" on top of it +- We still support very old hardware up to 10 years old, even if you raised this number WebGPU/etc require more modern APIs which would drop older hardware +- We don't want to expose the graphics library on Robust +- PROBLEM 2 (It's actually 3): +- We need to support Veldrid +- PROBLEM 3 (4): +- Older hardware +- this is still all just problem 2: "older hardware" she's just talking in a very roundabout funny manner +- Don't worry about it +- Maybe (maybe) use (maybe) WebGPU which uses the browser which reduces a lot of things you would need to create +- DirectX 10.1 hardware is what we target +- Visne left to go party, he is uncool +- Writing multiple backends: not good +- PJB is lost and confused, sad +- Just use Clyde :+1: +- Clyde2.0 When +- **If you want it easy drop OpenGL support** + - Less ass to maintain +- There are no plug-in rendering APIs +- Maybe get WebGPU or Vulkan-based, code against that, OpenGL is a fuck + + +## Early Access Roadmap +- gamemodes/antags + - dynamic | mirror + - lings? + - needs DNA + - blob | Remie + - revolutionaries + - we want a generic antag overlay system + - loyalty implant + - faction system +- EL BODY SYSTEM | jez ![](https://cdn.discordapp.com/emojis/933790288860815380.webp =40x) + - some refactors were done by mirror, still some left + - surgery died in the war of 1992 + - Mirror died in the war of 1993 + - limb damage..... +- Salvage proc gen | moony + - she did it go port it https://github.com/Citadel-Station-13/space-station-14/tree/master/Content.Server/_Citadel/Worldgen +- body system but again +- body system +- __***ENGINE EDITOR***__ | PJB + - could benefit from full state reload +- movement refactor + - Client side movement? + - a smidgen + - as a treat + - acruid pls com bak +- Add more shit to the guidebook +- combat rework (needs to be bikeshedded) + - https://github.com/space-wizards/space-station-14/issues/3378 +- ghostrole/antag bans + - unify ghost roles prototype (mind refactor) +- experimental science + - "Science is still a piece of shit" - Vera 28/05/2022 + - "I haven't played the game in 2 years" - Vera 07/01/2023 +- State mandated Xonotic matches | PJB + - Please I have severe withdrawal symptoms + - Replaced by private SS14 playtests + - Woman down + - She added Miku to her server (real) now you can play as miku pls play with her +- The game runs like shit how do people play this + - still does | PJB 28/05/2022 + - "how do people play this game" (high pitched scream) | PJB 28/05/2022 + - Slightly better | PJB 11/06/2022 + - It's better but still not as good as I'd like it to be | PJB 25/06/2022 + - I haven't played the game since | PJB 16/07/2022 + - "Please read the last line of that subsection" | PJB 30/07/2022 + - "Please unread the last line of the previous subsection" | PJB 07/01/2023 + - "I spent the last two weeks coding Rain World" | PJB 21/01/2023 +- A trailer for Steam + +Crashes / Critical bugs: (when are we moving these to GitHub) +- role timers not counting properly + => till next time diff --git a/src/en/maintainer-meetings/maintainer-meeting-2023-02-11.md b/src/en/maintainer-meetings/maintainer-meeting-2023-02-11.md new file mode 100644 index 000000000..889def06c --- /dev/null +++ b/src/en/maintainer-meetings/maintainer-meeting-2023-02-11.md @@ -0,0 +1,139 @@ +# Maintainer Meeting (11 February 2023) +```admonish info +Any decisions taken in these notes may no longer be applicable. +``` + +**Time:** 11 February 2023 19:00 UTC + +**Attendees:** +- Remie +- keronshb +- ElectroSR +- DrSmugleaf +- Vera +- PJB +- moony +- Visne +- Jezithyr +- flipp +- Zoldorf +- Wrexbe + +## Standardize and document naming for (system) dependencies | Vera +- [Discord message](https://discord.com/channels/310555209753690112/900426319433728030/1070066968419381320) +- [Original discussion](https://discord.com/channels/310555209753690112/770682801607278632/1070064771761709076) +- **Remove the prefix and suffix.** +- What about UIControllers, where there is SharedHandsSystem, HandsGUI, HandsUIController. +- Keep it explicit with `_handsSystem`. +- **Make a maintainer vote for whether or not we enforce this (either an analyzer or as part of review.)** + +## Debug vs DebugOpt vs Release vs ReleaseTools build configurations | PJB +- [Discord message](https://discord.com/channels/310555209753690112/900426319433728030/1072637756955693067) +- **Yes** +- Release (closest to the launcher version) would be closer to what we have for the downloadable public build (FULL_RELEASE). + - Can't be compiled easily because of filepath changes. +- Current release configuration (debug tools available) can become DebugOpt. +- Current debug configuration is the new Debug configuration. +- Tools (for mapping) is release with checks disabled and optimizations/tools enabled (tools is the launcher connect command). +- to summarize: + - `Debug`: optimizations disabled, asserts enabled, tools enabled. + - `DebugOpt`: optimizations enabled, asserts enabled, tools enabled. + - `Tools`: optimizations enabled, asserts disabled, tools enabled. + - `Release`: optimizations, asserts and tools disabled. As close to the launcher builds as you're gonna get while it stills runs from your repo. +- **Don't disable exception tolerance in debug.** + +## Medical refactor | Jezithyr +- [Discord message](https://discord.com/channels/310555209753690112/900426319433728030/1073932941878636624) +- This is basically old baymed (+ rimworld ~~+ EFT~~) +- Take notes on brainmed +- Don't make it overly complex +- Make cloning lategame/not a solution to everything + - And implement speedcloning where releasing someone too soon makes them miss body parts + +## Game admin tooling | DrSmugleaf +- [Discord message](https://discord.com/channels/310555209753690112/900426319433728030/1073933000204619807) (mistake) +- LOGS BAD (kind of) +- Not being able to search by username (have to correlate with the player list) + - Same in the player list +- Replays will help +- Add more buttons to the player panel (following players is ass) +- Make admin logs clickable (we have rich text now) +- Add UI for role bans +- Whitelist UI +- Admin wishlist [#13270](https://github.com/space-wizards/space-station-14/issues/13270) +- [Admin wishlist 2](https://github.com/space-wizards/space-station-14/issues?q=is%3Aopen+is%3Aissue+author%3A%40me+wishlist) +- [Admin wishlist 3](https://github.com/space-wizards/space-station-14/issues/13269) +- Fix not being able to use role ban and role time commands with offline players +- Add month and year to notes +- Greyscale/Grey out older notes +- Add UI to see a player's inventory including pocket items +- Admins can't see whispers +- Antag/ghost role bans +- Add categories to admin logs (groups of types) (not in the database, do it filtering on the frontend) +- Add a cvar to delete old admin logs + +## Server pop with the new large map | Pancake +- [Discord message](https://discord.com/channels/310555209753690112/900426319433728030/1073935104176562236) +- [Admin chat Discord message](https://discord.com/channels/310555209753690112/811324338099585036/1073934949633237092) +- Do we increase player cap + - idk + - **make a vote** + - **mirror take the wheel** +- Do we change the player cap based on the map + - probably not +- Do we make an US East server + - **yes** + +## Early Access Roadmap +- gamemodes/antags + - dynamic | mirror + - lings? + - needs DNA + - blob | Remie + - revolutionaries + - we want a generic antag overlay system + - loyalty implant + - faction system +- EL BODY SYSTEM | jez ![](https://cdn.discordapp.com/emojis/933790288860815380.webp =40x) + - some refactors were done by mirror, still some left + - surgery died in the war of 1992 + - Mirror died in the war of 1993 + - limb damage..... +- Salvage proc gen | moony + - she did it go port it https://github.com/Citadel-Station-13/space-station-14/tree/master/Content.Server/_Citadel/Worldgen +- body system but again +- body system +- __***ENGINE EDITOR***__ | PJB + - could benefit from full state reload +- movement refactor + - Client side movement? + - a smidgen + - as a treat + - acruid pls com bak +- combat rework (needs to be bikeshedded) + - https://github.com/space-wizards/space-station-14/issues/3378 +- ghostrole/antag bans +- experimental science + - "Science is still a piece of shit" - Vera 28/05/2022 + - "I haven't played the game in 2 years" - Vera 07/01/2023 + - "Uhhhhhhhhhhhhhhhhh I'm sorry EmoGarbage" - Vera 11/02/2023 +- State mandated Xonotic matches | PJB + - Please I have severe withdrawal symptoms + - Replaced by private SS14 playtests + - Woman down + - She added Miku to her server (real) now you can play as miku pls play with her +- The game runs like shit how do people play this + - still does | PJB 28/05/2022 + - "how do people play this game" (high pitched scream) | PJB 28/05/2022 + - Slightly better | PJB 11/06/2022 + - It's better but still not as good as I'd like it to be | PJB 25/06/2022 + - I haven't played the game since | PJB 16/07/2022 + - "Please read the last line of that subsection" | PJB 30/07/2022 + - "Please unread the last line of the previous subsection" | PJB 07/01/2023 + - "I spent the last two weeks coding Rain World" | PJB 21/01/2023 + - "I should've tried to run it from the AirBNB that I was staying over in my skiing trip but I didn't" | PJB 11/02/2023 +- A trailer for Steam + +Crashes / Critical bugs: (when are we moving these to GitHub) +- role timers not counting properly (pjb added a thing to check if its a db issue) (epico) + => till next time diff --git a/src/en/maintainer-meetings/maintainer-meeting-2023-03-05.md b/src/en/maintainer-meetings/maintainer-meeting-2023-03-05.md new file mode 100644 index 000000000..6276bb4b4 --- /dev/null +++ b/src/en/maintainer-meetings/maintainer-meeting-2023-03-05.md @@ -0,0 +1,118 @@ +# Maintainer Meeting (5 March 2023) +```admonish info +Any decisions taken in these notes may no longer be applicable. +``` + +> **Time:** 5 March 2023 19:00 UTC +> +> **Attendees:** +> - Wrexbe +> - Jezithyr +> - Visne +> - ElectroSR +> - PJB +> - DrSmugleaf +> - Paul +> - moony +> - keronshb + +## Re-enabling GitHub discussions | PJB +- Open them up to ideaguysing? +- We originally closed them because bot doesn't track them +- We disabled it because MoMMI doesn't post GitHub discussions in the github channel + - **If we agree that it's good PJB codes it** +- Verdict: **Yes** + +## YAML Prototype Editor | DrSmugleaf +- In-game or out-of-game + - If it's in-game it doesn't need to be downloaded separately but it can't be used if the branch doesn't build (can be solved by not using latest) + - Out of game means having to use avalonia :death: + - In-game means having to use robust's UI :death: + - In-game means it could live reload, and show it + - If the editor was good enough, we could store the data in a better format for machines +- Could be used by admins when uploading prototypes? +- Exporting to Resources/Prototypes when in local development +- Being able to view prototypes that have been uploaded through uploadfile in an UI? imagine +- **Don't do it out of game with Avalonia** +- **Do it in-game and maybe later move it to be inside a RobustToolbox editor** + + +## What to do about delta comp states | metalgearsloth +- Make comps track it themselves? https://discord.com/channels/310555209753690112/310555209753690112/1080275438913470564 +- Just use smaller components? (in the above case per-chunk ents but then that likely requires pvssystem changes and maybe archetypes) +- Pre-empting "do we need this" fixtures were split out from physics as grid movement was making the game unplayable for slow connections +- **Look into supporting chunk entities** + - **For bounds, chunks are multiples of 4 so it's not a problem** (i regard to chunk entities sitting at the corner of chunks) +- **Archetypes when** +- hampter, buncake + + +## Turning off settings requiring reviews to be approved | metalgearsloth +- It's just a placebo +- You can just dismiss it anyway. It doesn't need to remind me comments exist. +- I have already vibechecked the pr by that point even if I wasn't the reviewer. +- About as useful as protecting engine master +- Assuming it takes 5-10 seconds per PR this wastes 40+minutes a month +- Take a survey of active maints or smth idklol +- **Just use Bors you don't need to dismiss the reviews and Bors will fail if you merge something while it's working** + - **Ok don't do it yet until we fix the changelog bot** + + +## Early Access Roadmap +- gamemodes/antags + - dynamic | mirror + - lings? + - needs DNA + - blob | Remie + - revolutionaries + - we want a generic antag overlay system + - loyalty implant + - faction system +- EL BODY SYSTEM | jez ![](https://cdn.discordapp.com/emojis/933790288860815380.webp =40x) + - some refactors were done by mirror, still some left + - surgery died in the war of 1992 + - Mirror died in the war of 1993 + - limb damage..... +- Salvage proc gen | moony + - she did it go port it https://github.com/Citadel-Station-13/space-station-14/tree/master/Content.Server/_Citadel/Worldgen +- body system but again +- body system +- __***ENGINE EDITOR***__ | PJB + - could benefit from full state reload +- movement refactor + - Client side movement? + - a smidgen + - as a treat + - acruid pls com bak +- combat rework (needs to be bikeshedded) + - https://github.com/space-wizards/space-station-14/issues/3378 +- ghostrole/antag bans +- State mandated Xonotic matches | PJB + - Please I have severe withdrawal symptoms + - Replaced by private SS14 playtests + - Woman down + - She added Miku to her server (real) now you can play as miku pls play with her + - Implement Xonotic as a plugin to ss14 +- The game runs like shit how do people play this + - still does | PJB 28/05/2022 + - people like shitty games + - "how do people play this game" (high pitched scream) | PJB 28/05/2022 + - ex: SCREEEEEEEEE + - Slightly better | PJB 11/06/2022 + - It's better but still not as good as I'd like it to be | PJB 25/06/2022 + - I haven't played the game since | PJB 16/07/2022 + - "Please read the last line of that subsection" | PJB 30/07/2022 + - "Please unread the last line of the previous subsection" | PJB 07/01/2023 + - "I spent the last two weeks coding Rain World" | PJB 21/01/2023 + - "I should've tried to run it from the AirBNB that I was staying over in my skiing trip but I didn't" | PJB 11/02/2023 + - "It still runs like shit" | PJB 05/03/2023 +- A trailer for Steam + - Liltenhead made one + +Crashes / Critical bugs: (when are we moving these to GitHub) +- role timers not counting properly (pjb added a thing to check if its a db issue) (epico) + - the web ui just chops off after 24 hours haha + => till next time + like and subscribe + smash that button + did you know only 6% of contribs join this meeting? diff --git a/src/en/maintainer-meetings/maintainer-meeting-2023-05-06.md b/src/en/maintainer-meetings/maintainer-meeting-2023-05-06.md new file mode 100644 index 000000000..04fcc5513 --- /dev/null +++ b/src/en/maintainer-meetings/maintainer-meeting-2023-05-06.md @@ -0,0 +1,80 @@ +# Maintainer Meeting (6 May 2023) +```admonish info +Any decisions taken in these notes may no longer be applicable. +``` + +**Time:** 6 May 2023 19:00 UTC + +**Attendees:** +- DrSmugleaf +- Visne +- Flipp +- KeronSHB +- ShadowCommander +- mirrorcult + +## Dropping content support for disabling client-side prediction | ElectroSR +- **Simply make the server aware of which clients have prediction disabled instead** +- Might be annoying for the small amount of people that use it + +## Jez talks about telemetry | Jezithyr + +## Early Access Roadmap +- gamemodes/antags + - dynamic | mirror + - lings? + - needs DNA + - blob | Remie + - revolutionaries + - we want a generic antag overlay system + - loyalty implant + - faction system + - clock cult | keronshb +- EL BODY SYSTEM | jez ![](https://cdn.discordapp.com/emojis/933790288860815380.webp =40x) + - some refactors were done by mirror, still some left + - surgery died in the war of 1992 + - Mirror died in the war of 1993 + - limb damage..... +- Salvage proc gen | moony [c#15120](https://github.com/space-wizards/space-station-14/pull/15120) + - she did it go port it https://github.com/Citadel-Station-13/space-station-14/tree/master/Content.Server/_Citadel/Worldgen +- body system but again +- body system +- __***ENGINE EDITOR***__ + - could benefit from full state reload +- movement refactor + - Client side movement? + - a smidgen + - as a treat + - acruid pls com bak +- ghostrole/antag bans +- State mandated Xonotic matches | PJB + - Please I have severe withdrawal symptoms + - Replaced by private SS14 playtests + - Woman down + - She added Miku to her server (real) now you can play as miku pls play with her + - Implement Xonotic as a plugin to ss14 +- The game runs like shit how do people play this + - still does | PJB 28/05/2022 + - people like shitty games + - "how do people play this game" (high pitched scream) | PJB 28/05/2022 + - ex: SCREEEEEEEEE + - Slightly better | PJB 11/06/2022 + - It's better but still not as good as I'd like it to be | PJB 25/06/2022 + - I haven't played the game since | PJB 16/07/2022 + - "Please read the last line of that subsection" | PJB 30/07/2022 + - "Please unread the last line of the previous subsection" | PJB 07/01/2023 + - "I spent the last two weeks coding Rain World" | PJB 21/01/2023 + - "I should've tried to run it from the AirBNB that I was staying over in my skiing trip but I didn't" | PJB 11/02/2023 + - "It still runs like shit" | PJB 05/03/2023 + - "Uh" | PJB 19/03/2023 + - "Smugleaf to answer the literal question posed, because its better than Byond I hope" | PJB 01/04/2023 + - "Well I have a sample size of 1 myself and I do believe people do not in fact play the game" | PJB 15/04/2023 +- A trailer for Steam + - Also the screenshots for steam and the website + +Crashes / Critical bugs: (when are we moving these to GitHub) +- admin player overlay broke + => till next time + like and subscribe + smash that button + did you know only 6% of contribs join this meeting? diff --git a/src/en/maintainer-meetings/maintainer-meeting-2023-05-20.md b/src/en/maintainer-meetings/maintainer-meeting-2023-05-20.md new file mode 100644 index 000000000..b5a0ef312 --- /dev/null +++ b/src/en/maintainer-meetings/maintainer-meeting-2023-05-20.md @@ -0,0 +1,117 @@ +# Maintainer Meeting (20 May 2023) +```admonish info +Any decisions taken in these notes may no longer be applicable. +``` + +**Time:** 20 May 2023 19:00 UTC + +**Attendees:** +- DrSmugleaf +- flipp +- metalgearsloth +- ShadowCommander +- PJB +- Visne +- keronshb +- ElectroSR +- Jezithyr +- mirrorcult + +## Component shutdown events | ElectroSR +- Should we combine ComponentShutdown and ComponentRemove events? + - Yes, but also remove the separation between component Add and Init (and Startup) + - Also remove component enabling/disabling +- Should we add a new event that only gets raised when a component is explicitly removed, rather than due to entity deletion. Standard removal events would still get raised. + - Context: removal logic that is a waste of time if the entity is just getting deleted anyways. + - Components shouldn't do complex work in removal/deletion. Deletion should just get rid of things as aggressively as possible, only keeping the game state consistent. + - Removal of components should be private to systems rather than a public API. Systems should do "on removal" logic themselves in a public function that removes components for you. + - Make it opt in (Access attribute). + - Keep a deletion event if the entity is deleted altogether, but don't fire it if individual component is removed. + - Combined with the earlier point, this means that if you ABSOLUTELY MUST run code on all component removals, you need to explicitly call it from both your public removal function AND on deletione event. + - Keep a component removal event in case some use case really needs it. +- If we have a separate explicit removal event, can we eventually remove InSafeOrder() & just enforce that component removal doesn't require querying other components on that entity? + - **YES** + +Edit with bonus questions: +- If the events are merged, what do we do with deffered component removal. Currently it raises a shutdown event, but defers the remove event & actual removal. + - idk +- Also: should events be raised for components that are deferred for removal (i.e., should the subscription enumerator check the component's lifestage?) + - idk 2 + + +## UI stylesheets and themes | ElectroSR +- Meeting topic/discussion: Stylesheets & themes. +- How do we make them better? Stylesheets and rich text should probably use themes when possible. + +- Decision: + - Combine stylesheets and themes, move it to YAML + - Context: stylesheets are originally C# because they need to be able to describe C# objects like style boxes, and `.css` can't do that. + - Whoever makes the YAML syntax has to figure out how to implement constants for re-use in the stylesheet. + - Make it easy to extend stylesheets (edits of simple properties, colors etc). + - For complex animations/styling of controls, content should inherit engine controls and implement logic there. + - We will not be implementing more complex styling functions from CSS like built-in transitions, aniamtions, descendant selector. + + +## Arch | DrSmugleaf +- Smug giving status updates on Arch + - She's ranting I love it when she has this energy. + - She's explaining it again + + +## Early Access Roadmap +- gamemodes/antags + - dynamic [c#16548](https://github.com/space-wizards/space-station-14/pull/16548) + - lings? [c#16513](https://github.com/space-wizards/space-station-14/pull/16513) + - needs DNA + - blob + - revolutionaries + - we want a generic antag overlay system + - loyalty implant + - faction system + - clock cult | keronshb +- EL BODY SYSTEM | jez (sloth?) ![](https://cdn.discordapp.com/emojis/933790288860815380.webp =40x) + - some refactors were done by mirror, still some left + - surgery died in the war of 1992 + - Mirror died in the war of 1993 + - limb damage..... +- body system but again +- body system +- __***ENGINE EDITOR***__ + - could benefit from full state reload +- movement refactor + - Client side movement? + - a smidgen + - as a treat + - acruid pls com bak +- ghostrole/antag bans +- State mandated Xonotic matches | PJB + - Please I have severe withdrawal symptoms + - Replaced by private SS14 playtests + - Woman down + - She added Miku to her server (real) now you can play as miku pls play with her + - Implement Xonotic as a plugin to ss14 +- The game runs like shit how do people play this + - still does | PJB 28/05/2022 + - people like shitty games + - "how do people play this game" (high pitched scream) | PJB 28/05/2022 + - ex: SCREEEEEEEEE + - Slightly better | PJB 11/06/2022 + - It's better but still not as good as I'd like it to be | PJB 25/06/2022 + - I haven't played the game since | PJB 16/07/2022 + - "Please read the last line of that subsection" | PJB 30/07/2022 + - "Please unread the last line of the previous subsection" | PJB 07/01/2023 + - "I spent the last two weeks coding Rain World" | PJB 21/01/2023 + - "I should've tried to run it from the AirBNB that I was staying over in my skiing trip but I didn't" | PJB 11/02/2023 + - "It still runs like shit" | PJB 05/03/2023 + - "Uh" | PJB 19/03/2023 + - "Smugleaf to answer the literal question posed, because its better than Byond I hope" | PJB 01/04/2023 + - "Well I have a sample size of 1 myself and I do believe people do not in fact play the game" | PJB 15/04/2023 + - "Well I mean well ok we are somewhat close to being able to play the game, I still haven't played the game however" | PJB 20/05/2023 +- A trailer for Steam + - Also the screenshots for steam and the website + +Crashes / Critical bugs: (when are we moving these to GitHub)ç +=> till next time +like and subscribe +smash that button +did you know only 6% of contribs join this meeting? diff --git a/src/en/maintainer-meetings/maintainer-meeting-2023-06-10.md b/src/en/maintainer-meetings/maintainer-meeting-2023-06-10.md new file mode 100644 index 000000000..0989e5eea --- /dev/null +++ b/src/en/maintainer-meetings/maintainer-meeting-2023-06-10.md @@ -0,0 +1,126 @@ +# Maintainer Meeting (10 Jun 2023) +```admonish info +Any decisions taken in these notes may no longer be applicable. +``` + +**Time:** 10 Jun 2023 19:00 UTC + +**Attendees:** +- DrSmugleaf +- PJB +- ElectroSR +- KeronSHB + +## Target round length | ShadowCommander +- How long? + - Citadel is too long at 2 sometimes not + - Really depends on what's going on in the round + - **60/90 minutes and give admins permissions to extend the shift** +- **Not hard-forced mechanically** + - i.e. no forced un-recallable shuttle at 90 minute mark + - If someone holds the round hostage others AHelp it +- **If we want to end the round, start ramping up events and disaster on the round** + - Overridable by admins + - Maybe override with player vote? + - Obviously tune for MRP + - Should take state of round into account +- Add a TF2 payload cart to SS14 + +## Formatting for log sawmills | metalgearsloth +- Options: + - name + - name.othername + - name_name + - Name + - Name.Name + - Name_Name + +- **Decision**: + - snake case elements + - example: `foo_bar.baz` + +## Obsolete freeze | PJB +![](https://hackmd.io/_uploads/B17h1SMP2.png) + +- Fucking fix the code reeee +- **"Just don't obsolete anything that's on the tier of `.Owner` for now probably"** +- **No content freezes or anything like that, it doesn't work** + +## IoCManager resolves in UI code | PJB +- UI controls currently rely on `IoCManager.Resolve()` in current +- **Option 1: constructor parameter** + - `new Control(UI)` + - First parameter becomes `IUserInterfaceManager` + - Must be passed through manually when creating new controls + - XamlUI does it automatically, only relevant for dynamic control creation. + - Hopefully not too inconvenient, have a `UI` property you can pass through easily. + - Add `IDependencyCollection` property to `IUserInterfaceManager` to link it through. + +- ~~Option 2~~: + - UI manager gets passed through on tree attach (when you add control as child of another one). + - Means no needing to pass constructor parameter manually. + - Fetching dependencies like sawmills must be done from `EnteredTree()` instead. + - Add `IDependencyCollection` property to `IUserInterfaceManager` to link it through. + +## How do we make PRs easier to review +- **We don't know** + +## Early Access Roadmap +- gamemodes/antags + - dynamic [c#16548](https://github.com/space-wizards/space-station-14/pull/16548) + - lings? [c#16513](https://github.com/space-wizards/space-station-14/pull/16513) + - needs DNA + - blob + - revolutionaries + - we want a generic antag overlay system + - loyalty implant + - faction system + - clock cult | keronshb + - waiting for mind rework +- EL BODY SYSTEM | jez (sloth?) ![](https://cdn.discordapp.com/emojis/933790288860815380.webp =40x) + - some refactors were done by mirror, still some left + - surgery died in the war of 1992 + - Mirror died in the war of 1993 + - limb damage..... +- body system but again +- body system +- __***ENGINE EDITOR***__ + - could benefit from full state reload +- movement refactor + - Client side movement? + - a smidgen + - as a treat + - acruid pls com bak +- ghostrole/antag bans +- State mandated Xonotic matches | PJB + - Please I have severe withdrawal symptoms + - Replaced by private SS14 playtests + - Woman down + - She added Miku to her server (real) now you can play as miku pls play with her + - Implement Xonotic as a plugin to ss14 +- The game runs like shit how do people play this + - still does | PJB 28/05/2022 + - people like shitty games + - "how do people play this game" (high pitched scream) | PJB 28/05/2022 + - ex: SCREEEEEEEEE + - Slightly better | PJB 11/06/2022 + - It's better but still not as good as I'd like it to be | PJB 25/06/2022 + - I haven't played the game since | PJB 16/07/2022 + - "Please read the last line of that subsection" | PJB 30/07/2022 + - "Please unread the last line of the previous subsection" | PJB 07/01/2023 + - "I spent the last two weeks coding Rain World" | PJB 21/01/2023 + - "I should've tried to run it from the AirBNB that I was staying over in my skiing trip but I didn't" | PJB 11/02/2023 + - "It still runs like shit" | PJB 05/03/2023 + - "Uh" | PJB 19/03/2023 + - "Smugleaf to answer the literal question posed, because its better than Byond I hope" | PJB 01/04/2023 + - "Well I have a sample size of 1 myself and I do believe people do not in fact play the game" | PJB 15/04/2023 + - "Well I mean well ok we are somewhat close to being able to play the game, I still haven't played the game however" | PJB 20/05/2023 + - "It still runs pretty bad however I do understand how people play it" | PJB 10/06/2023 +- A trailer for Steam + - Also the screenshots for steam and the website + +Crashes / Critical bugs: (when are we moving these to GitHub) +=> till next time +like and subscribe +smash that button +did you know only 6% of contribs join this meeting? diff --git a/src/en/maintainer-meetings/maintainer-meeting-2023-07-29.md b/src/en/maintainer-meetings/maintainer-meeting-2023-07-29.md new file mode 100644 index 000000000..a0bbdfae2 --- /dev/null +++ b/src/en/maintainer-meetings/maintainer-meeting-2023-07-29.md @@ -0,0 +1,148 @@ +# Maintainer Meeting (29 Jul 2023) +```admonish info +Any decisions taken in these notes may no longer be applicable. +``` + +**Time:** 29 Jul 2023 19:00 UTC + +**Attendees:** +- EmoGarbage +- Visne +- Wrexbe +- ElectroSR +- PJB +- Chief_Engineer +- Moony +- Notafet + +## Ambiguity of rule-relevant information in-game - Chief Engineer +* Certain rules are unclear at least partially because the game doesn't do a great job of presenting certain types of information to the player. This can result in confusion around certain rules, particularly for players who don't spend a significant amount of time in the game. + +* This is the information I can think of that should be clearly presented in-game: +* Antag status, including for ghost roles + * Example: Slimes clearly™️ communicate their antag status in their role description, but this is inconsistent with other ghost roles which also have ghost role rules saying that they are an antag. + * **On spawn (regular jobs & ghost roles), the character window should always open.** + * **Character menu gets far more info such as antag status, job expectation, etc... Actually make it useful!** + * **For ghost roles, add lottery, so people have time to read the role's description.** + * **This should provide people unmissable info what's expected of them (e.g. if they're antag), if people still wanna be friendly in an RP game we can't stop them.** + * What is contraband, specifically what is non-stealth contraband + * This is info for the antag player (in the item status box), so people realize what they're buying is contraband. + * **Silly stuff like syndicate balloon isn't really contraband: security can't assume you're a traitor.** + * ![](https://hackmd.io/_uploads/HJFTnRMjh.png) + * **No explicit indication for obvious crap like emag, power sink, etc. Players should use their brain, but do have good descriptions for it.** + * What are high value items, things that shouldn't be given away by heads + * People don't realize you can't *just* give the hypospray away. + * **Put a list of high-value items in the guidebook.** + * Which bodies can be returned to [#8495](https://github.com/space-wizards/space-station-14/issues/8495). + * **Make sure it's clearly explained in the guidebook.** + * **Make sure it makes sense.** + * **Doesn't need to be 100% obvious whether a corpse is revivable or not just from examine text, minimum should be health analyzer.** + +> What is the best way to present this information to players in-game? Many players miss that xenos, whose description includes "kill all crewmembers", are antags. Is this just a skill issue, or can it be mitigated with game changes? +How do you communicate what is a high value item without encouraging/justifying things like throwing it in the vault round start +What's the best way to ensure that contributors are aware that this information needs to be presented to players? +Is there a way the contraband status of stealth items can be communicated without ruining their stealth? + +mucho texto + +**See bullet points above** + +## Salvage Design Direction maintainer meeting topic - Emisse +(what's the opposite of mucho) texto +* tstalker says it's poco. + +According to EmoGarbage: Used to just have magnet salvage. Pull shit in, mine it. Now we have expeditions (~10min): fly to length, procgen dungeon. These are very different and it's not clear how this shit fit into gameplay. + +* **Make expeditions shorter & faster** + * **~5 min max time limit** + * **Corpse recovery if left behind** + * **stuff to make looting faster: mark items to be teleported, no inventory management** + * **Just make it more gamey** + * **Force a cooldown between expeditions. People can do magnet salvage if they want, but it's not required** + +## Spawn coordinates naming - ElectroSR +* Should we rename the entity spawn variant that takes in entity coordinates to clarify that it spawns-then-attaches or something like that +* **Yes, make more clear naming.** +* **A lot of helper functions.** +* **We need explicit helpers for common scenarios like "spawn next to player" (accounting for containers).** + +## What kinds of gamemodes are acceptable upstream? - EmoGarbage +* What kinds of gamemodes are acceptable upstream? +* Current gamemodes are all on-station regular stuff. People have jobs, antags happen. +* Some idea for more devious game modes: + * Planet tower defense + * Team deathmatch + * STATIONWARE +* Do we run total conversion and NRP modes (TDM, etc) +* What kinds of modes should be opt-in vs. part of secret +* **People can vote for alt gamemodes, within population ranges (e.g. 20 players max for TDM). +* **Alt gamemodes are WYCI** + +## Antags: to midround or not? - EmoGarbage +* What modes should be roundstart / in secret +* What modes/antagonists should remain as midrounds +* **We're just bikeshedding dynamic/game director. I think we're all in agreement there's nothing special to decide here** + +## Early Access Roadmap +- gamemodes/antags + - dynamic [c#16548](https://github.com/space-wizards/space-station-14/pull/16548) + - lings? [c#16513](https://github.com/space-wizards/space-station-14/pull/16513) + - needs DNA + - blob + - revolutionaries + - we want a generic antag overlay system + - loyalty implant + - faction system + - clock cult | keronshb + - waiting for mind rework +- EL BODY SYSTEM | jez (sloth?) ![](https://cdn.discordapp.com/emojis/933790288860815380.webp =40x) + - some refactors were done by mirror, still some left + - surgery died in the war of 1992 + - Mirror died in the war of 1993 + - limb damage..... +- body system but again +- body system + - Maybe if we hold the VRChat maintainer meeting +- __***ENGINE EDITOR***__ + - could benefit from full state reload +- movement refactor + - Client side movement? + - a smidgen + - as a treat + - acruid pls com bak + - What does this even mean anymore? +- ghostrole/antag bans +- State mandated Xonotic matches | PJB + - Please I have severe withdrawal symptoms + - Replaced by private SS14 playtests + - Woman down + - She added Miku to her server (real) now you can play as miku pls play with her + - Implement Xonotic as a plugin to ss14 +- The game runs like shit how do people play this + - still does | PJB 28/05/2022 + - people like shitty games + - "how do people play this game" (high pitched scream) | PJB 28/05/2022 + - ex: SCREEEEEEEEE + - Slightly better | PJB 11/06/2022 + - It's better but still not as good as I'd like it to be | PJB 25/06/2022 + - I haven't played the game since | PJB 16/07/2022 + - "Please read the last line of that subsection" | PJB 30/07/2022 + - "Please unread the last line of the previous subsection" | PJB 07/01/2023 + - "I spent the last two weeks coding Rain World" | PJB 21/01/2023 + - "I should've tried to run it from the AirBNB that I was staying over in my skiing trip but I didn't" | PJB 11/02/2023 + - "It still runs like shit" | PJB 05/03/2023 + - "Uh" | PJB 19/03/2023 + - "Smugleaf to answer the literal question posed, because its better than Byond I hope" | PJB 01/04/2023 + - "Well I have a sample size of 1 myself and I do believe people do not in fact play the game" | PJB 15/04/2023 + - "Well I mean well ok we are somewhat close to being able to play the game, I still haven't played the game however" | PJB 20/05/2023 + - "It still runs pretty bad however I do understand how people play it" | PJB 10/06/2023 +- A trailer for Steam + - Also the screenshots for steam and the website + - holy shit we have replays now + + +Crashes / Critical bugs: (when are we moving these to GitHub) +=> till next time +like and subscribe +smash that button +did you know only 6% of contribs join this meeting? diff --git a/src/en/maintainer-meetings/maintainer-meeting-2023-08-19.md b/src/en/maintainer-meetings/maintainer-meeting-2023-08-19.md new file mode 100644 index 000000000..d983f513f --- /dev/null +++ b/src/en/maintainer-meetings/maintainer-meeting-2023-08-19.md @@ -0,0 +1,201 @@ +# Maintainer Meeting (19 Aug 2023) +```admonish info +Any decisions taken in these notes may no longer be applicable. +``` + +**Time:** 19 Aug 2023 18:00 UTC + +**Attendees:** +- Visne +- ElectroSR +- Metalgearsloth +- ShadowCommander +- PJB +- DrSmugleaf +- Julian +- Mirrorcult +- Notafet +- TheQuietOne +- Faint +- Jezithyr +- EmoGarbage + +![](https://hackmd.io/_uploads/SJ_QSYAhh.png) omg miku + +## Namespace changes in content | metalgearsloth +- https://github.com/space-wizards/space-station-14/pull/18869#issuecomment-1672388772 +- client and server end with s but shared doesn't so it was updated +- PR is also making component changes +- IMO no because it's cleaning up code so it's actually consistent +- **Do it in standalone PRs unless the PR is very small** + * Better for reviewing and forks +- **Post breaking changes in #codebase-changes AND THE GITHUB DISCUSSIONS ANNOUNCEMENTS** + +## Conventions for locale strings | EmoGarbage +- there is literally no rhyme or reason anywhere +- there isn't a guideline for what the locale key is supposed to look like +- the file structure is a literal hellhole of a million folders with a single file inside of them +- it doesn't even mirror Prototypes or the c# code file structure +- "Does anybody even use the file tree?" - Smug +- Mirror idea: what if they're top-level popup/, verb/, prototype/, etc. + - Would make future rewriting easier. + - **Just always have `verb-` or `popup-` or `ui` in the key for that purpose.** +- **Mirror C# structure** + - Mostly used from C#: popups, verbs, etc.. + - C# structure is *fine*, could be better but ah well. + +## How do we handle reagents with extra data | ElectroSR +- IMO we should extend solutions to also be able to store non-prototype / complex reagents that aren't simply an ID string. +- How would complex reagents store data? Would it just be an instance of some class per solution or would they point to some shared instance/entity? +- If its a shared entity, how do we handle: +- PVS +- Deleting the entity when all solutions are gone. +- Cloning an entity if one of several solutions gets modified (e.g., dna damage). +--- +Comments: +- IMO it would probably be easiest to just have complex reagents be instances of some class that defines special behaviour in C#. Allowing them to be entities probably just overcomplicates this? +- this has definitely been brought up before, but I don't remember what the conclusions were +- if there even were any + +--- + +- ![](https://hackmd.io/_uploads/SJOE9tR2h.png) +- **(Make it some base type other than object, figure out how to do automatic merging behavior)** +- Idea is this data object would be copied + +## Don't speedmerge large content PRs | metalgearsloth +- specifically [c#18840] and [c#18136] (TEG and borgs) +- I know they're both maintainers but at a glance I can see a lot of standards not being applied +- there's a lot of older prs that still need reviewing +- having a maint get their 5k line pr get merged while your small pr is still sitting there is a kick in the guts +--- +- personally: +- I'd rather playtest after someone's reviewed it thoroughly so if there's no major issues we can keep it rather than expect every time for it to get reverted. This is to avoid stuff like the ninja pr which sat in review hell for months +- There's a risk that some big, really not up-to-standards code gets merged and then people get unhappy when it needs reverting, or the bigger risk that it just stays there. +- **Have it be moderately ready for test merges** +- **Remember test merges** +- **Try to notify game admins for roles and gamerules (events)** + +## IMPROMPTU TOPIC: Contributor survey | Mirrorcult +- Do it sometime soon™ + +## Derailment +OH MY GOD WE HAVE 700 MERGED PRs LAST MONTH ALMOST TWICE OTHER CODEBASES. + +## Change how we do !logging | Visne +- !logging tells you to dm a random maintainer who may not know how it works and may have to message someone else +- Logs may have PII +- **Remove PII from logs so they can be posted in public channels** + - **Edit the !logging command** +- **Eventually have some ticketing system that lets every maintainer look at it** +- Ticket system is a massive pipe dream lmao wyci + +## Net entities | metalgearsloth +- how do we handle commands for migration (I'm just assuming they should all take NetEntity atm) +- anything else that may come up +- **Write a migration guide for forks** + +## Arch migration | metalgearsloth +- after the initial arch port to swap out internals what else do we want to take advantage of / how in terms of what I think is priority e.g.: +- queries (and how we prefer to structure it content side) https://github.com/genaray/Arch/wiki/Query-techniques +- command buffer (to replace RemCompDeferred / other stuff editing in loops), would we just expose this directly, do we flush it after every update, do we store one on EntityManager and flush it at the end of ticks etc. https://github.com/genaray/Arch/wiki/Utility-Features +- eventbus +- job scheduling (replace my shitty parallel.for everywhere) +- relations +- **its good** + +## Named args enforcement | metalgearsloth +- so emote sounds broke and it turns out adding an extra arg to the emotes method shifted everything and broke it. +- should we enforce this in review, even just past a certain point (e.g. 3 args) to avoid bools suddenly being mixed up or is this just a skill issue. + - **Enforce it in review when we decide the guidelines.** +- alternatively chat system is so fucking bad this was bound to happen (freeze until refactor PLEASE). +- **Maybe write an analyzer for it** +- **Also figure out how long it takes to run analyzers** + +## Default values in component C# definitions | PJB +- HAS THIS HAPPENED TO YOU? +- You define a component in C#. You only need it for one thing right now. Instead of putting the value in the YAML, you put it in the C# +- Should we put this as a no-no in the conventions? +- **Do it case-by-case** + +## Additional changelog categories/types for codebase changes and pretty/lore versions | ShadowCommander +- **Do it for codebase and game admin changes that can be filtered.** +``` +**Changelog** + +:cl: PJB3005 +[Gameplay] +- add: Nanotrasen finally decided to give engineering departments something to do, and has finalized the schematics for the thermo-electric generator (TEG). +- add: The TEG creates power by exchanging energy between a hot and cold gas on its two sides. +- tweak: You can turn on gas heaters/freezers with alt-click now. +- tweak: You can open air alarm and pump menus with activate (E) now. +``` +- **Have separate files and ids for any channels (admin/fork) so forks can also have their own.** + +## Early Access Roadmap +- gamemodes/antags + - dynamic [c#16548](https://github.com/space-wizards/space-station-14/pull/16548) + - lings? [c#16513](https://github.com/space-wizards/space-station-14/pull/16513) (closed) + - needs DNA + - blob + - revolutionaries [c#18477](https://github.com/space-wizards/space-station-14/pull/18477) + - we want a generic antag overlay system + - loyalty implant + - faction system + - clock cult | keronshb + - waiting for mind rework +- EL BODY SYSTEM | jez ![](https://cdn.discordapp.com/emojis/933790288860815380.webp =40x) + - some refactors were done by mirror, still some left + - surgery died in the war of 1992 + - Mirror died in the war of 1993 + - limb damage..... +- body system but again +- body system + - Maybe if we hold the VRChat maintainer meeting +- __***ENGINE EDITOR***__ + - could benefit from full state reload +- movement refactor + - Client side movement? + - a smidgen + - as a treat + - acruid pls com bak + - What does this even mean anymore? + - what is an 'acruid'? +- ghostrole/antag bans + - for ghost roles make taking them not valid if role-banned +- State mandated Xonotic matches | PJB + - Please I have severe withdrawal symptoms + - Replaced by private SS14 playtests + - Woman down + - She added Miku to her server (real) now you can play as miku pls play with her + - Implement Xonotic as a plugin to ss14 +- The game runs like shit how do people play this + - still does | PJB 28/05/2022 + - people like shitty games + - "how do people play this game" (high pitched scream) | PJB 28/05/2022 + - ex: SCREEEEEEEEE + - Slightly better | PJB 11/06/2022 + - It's better but still not as good as I'd like it to be | PJB 25/06/2022 + - I haven't played the game since | PJB 16/07/2022 + - "Please read the last line of that subsection" | PJB 30/07/2022 + - "Please unread the last line of the previous subsection" | PJB 07/01/2023 + - "I spent the last two weeks coding Rain World" | PJB 21/01/2023 + - "I should've tried to run it from the AirBNB that I was staying over in my skiing trip but I didn't" | PJB 11/02/2023 + - "It still runs like shit" | PJB 05/03/2023 + - "Uh" | PJB 19/03/2023 + - "Smugleaf to answer the literal question posed, because its better than Byond I hope" | PJB 01/04/2023 + - "Well I have a sample size of 1 myself and I do believe people do not in fact play the game" | PJB 15/04/2023 + - "Well I mean well ok we are somewhat close to being able to play the game, I still haven't played the game however" | PJB 20/05/2023 + - "It still runs pretty bad however I do understand how people play it" | PJB 10/06/2023 + - "Still does" | PJB 19/08/2023 +- A trailer for Steam + - Also the >>>>**screenshots**<<<< for steam and the website + - DO WE HAVE SELF GHOST HIDING + - holy shit we have **replays** now + + +Crashes / Critical bugs: (when are we moving these to GitHub) +=> till next time +like and subscribe +smash that button +did you know only 6% of contribs join this meeting? diff --git a/src/en/maintainer-meetings/maintainer-meeting-2023-09-02.md b/src/en/maintainer-meetings/maintainer-meeting-2023-09-02.md new file mode 100644 index 000000000..2833088a5 --- /dev/null +++ b/src/en/maintainer-meetings/maintainer-meeting-2023-09-02.md @@ -0,0 +1,129 @@ +# Maintainer Meeting (02 Sep 2023) +```admonish info +Any decisions taken in these notes may no longer be applicable. +``` + +**Time:** 02 Sep 2023 18:00 UTC + +**Attendees:** +- EmoGarbage +- Visne +- Julian +- ShadowCommander +- ElectroSR +- Lank +- Notafet +- PJB +- Faint + +## "the github reviews murder case special" +- get rid of codeowners. do any of us actually use it, it just confuses people who think the codeowners need to review before its merged + - **Remove all general ones and change to one or two folders deep, so that it actually goes to the relevant PRs +- review labels rn are half-automated which is good but its hard to tell when someone finishes a review. have people re-request a review on github to clear the ‘changes requested’ label and expect ppl to do this + - Make the bot remove the "Awaiting changes" label when PR reviews are requested again + - Just tell more people to press the re-request review button when reviewing. + - Maybe make a copy paste that can be put as the instructions for new contributors +- have maintainers actually assign themselves to review PRs that they're going to review so we aren't just passing this along through word of mouth +- ok basically just actually make use of the GH review features instead of having to tell people ‘uhh just ignore that’ +- side quest. can we ask github for GH enterprise again since we're big boys and open source + +## "a killing at the github issues and labels page " +- get rid of all prio labels except for URGENT they dont rly matter + - We probably wont sort by + or - Low Priority, so + - **Yes only URGENT** +- maybe consolidate the difficulty labels too but theyre probably fine + - **Keep difficulty labels** + - Easy should be able to be done by a new contributor with 0-4 PRs within a few hours. + - Beginner friendly should be clearly written out what the requirements and goals are for the PR +- mapping issue labels (one for every map? makes it easier for mappers to sort through) + - Not needed +- some ‘possibly no longer relevant' label (like tgs ‘flagged cleanup’label), close really old issues with this if we aren't 100% sure + - some other ideas for issue labels that are actually useful: + - ‘oversight' (easy to fix random stuff that just wasnt caught) + - ‘regression’ (previously working feature is broken) + - combine cleanup/needs refactor into ‘code maintenance’ + - ‘requires resprite’for arttainer issues +- go back through and properly clean up and label old-old issues by god there are 2.2k open and they are definitely not all still relevant. let us start a united front here. give a bunch of people triage and go at it over the course of like a couple weeks. make github issues useful again +- allow user labeling of issues, at least for certain kinds like feature request and oversight. probably thru some gh action that just looks in the issue body or in comments. iirc someone tried this like 2 yrs ago but it didnt work and we never fixed it + - Yes fix the bot +- think about giving out triage access more freely, maybe to all experienced contribs? + - **Yes** + - And some game admins + - All staff + +## New art +- ok can we actually commission artists for new lobby art with our five million dollars like we said we would a year ago +- Yes. We need an artist. +- Lobby art ideas: + - One of every Antagonist + - One of every species + - One of every Job/Department + - This is not one artwork per subject, one artwork can have more than one subject. + +## Early Access Roadmap +- gamemodes/antags + - dynamic [c#16548](https://github.com/space-wizards/space-station-14/pull/16548) + - lings? [c#16513](https://github.com/space-wizards/space-station-14/pull/16513) (closed) + - needs DNA + - blob + - revolutionaries [c#18477](https://github.com/space-wizards/space-station-14/pull/18477) + - we want a generic antag overlay system + - loyalty implant + - faction system + - clock cult | keronshb + - waiting for mind rework +- EL BODY SYSTEM | jez ![](https://cdn.discordapp.com/emojis/933790288860815380.webp =40x) + - some refactors were done by mirror, still some left + - surgery died in the war of 1992 + - Mirror died in the war of 1993 + - limb damage..... +- body system but again +- body system + - Maybe if we hold the VRChat maintainer meeting +- __***ENGINE EDITOR***__ + - could benefit from full state reload +- movement refactor + - Client side movement? + - a smidgen + - as a treat + - acruid pls com bak + - What does this even mean anymore? + - what is an 'acruid'? +- ghostrole/antag bans + - for ghost roles make taking them not valid if role-banned +- State mandated Xonotic matches | PJB + - Please I have severe withdrawal symptoms + - Replaced by private SS14 playtests + - Woman down + - She added Miku to her server (real) now you can play as miku pls play with her + - Implement Xonotic as a plugin to ss14 +- The game runs like shit how do people play this + - still does | PJB 28/05/2022 + - people like shitty games + - "how do people play this game" (high pitched scream) | PJB 28/05/2022 + - ex: SCREEEEEEEEE + - Slightly better | PJB 11/06/2022 + - It's better but still not as good as I'd like it to be | PJB 25/06/2022 + - I haven't played the game since | PJB 16/07/2022 + - "Please read the last line of that subsection" | PJB 30/07/2022 + - "Please unread the last line of the previous subsection" | PJB 07/01/2023 + - "I spent the last two weeks coding Rain World" | PJB 21/01/2023 + - "I should've tried to run it from the AirBNB that I was staying over in my skiing trip but I didn't" | PJB 11/02/2023 + - "It still runs like shit" | PJB 05/03/2023 + - "Uh" | PJB 19/03/2023 + - "Smugleaf to answer the literal question posed, because its better than Byond I hope" | PJB 01/04/2023 + - "Well I have a sample size of 1 myself and I do believe people do not in fact play the game" | PJB 15/04/2023 + - "Well I mean well ok we are somewhat close to being able to play the game, I still haven't played the game however" | PJB 20/05/2023 + - "It still runs pretty bad however I do understand how people play it" | PJB 10/06/2023 + - "Still does" | PJB 19/08/2023 +- A trailer for Steam + - Also the >>>>**screenshots**<<<< for steam and the website + - DO WE HAVE SELF GHOST HIDING + - holy shit we have **replays** now + + +Crashes / Critical bugs: (when are we moving these to GitHub) +=> till next time +like and subscribe +smash that button +did you know only 6% of contribs join this meeting?