Skip to content
This repository has been archived by the owner on Nov 9, 2019. It is now read-only.

Tag value warnings #19

Open
JitGub opened this issue Jan 8, 2017 · 6 comments
Open

Tag value warnings #19

JitGub opened this issue Jan 8, 2017 · 6 comments

Comments

@JitGub
Copy link

JitGub commented Jan 8, 2017

It looks like the Rosemary editor can create a tag that gives warnings in JOSM editor version 11441.

Changeset: 34767398

Node: 462911379
Version 8
created_by rosemary v0.4.4

wheelchair:description

There are 2 warnings:

Multiple white spaces
Character code less than 0x20

@JitGub
Copy link
Author

JitGub commented Jan 8, 2017

Forgot to add screen dump:
warnings tag

@christoph-buente
Copy link
Contributor

This error message does not make any sense to me. Is it because of multiple whitespaces in the description text? Or is there a special character in it?

@JitGub
Copy link
Author

JitGub commented Jan 30, 2017

Both, see hex-dump.
wheelchair_description

@christoph-buente
Copy link
Contributor

Ok, thanks for providing that. Even then I'm not sure if it wasn't job of the API to make sure clients don't send "malicious" data and refuse to serve these API calls.

It's easy to implement a check for double whitespaces. But hey, i can see people with pitchforks and torches coming after me because there is a very good reason to support double whitespaces as tag values.

What is the statement of the OSM API maintainers?

@JitGub
Copy link
Author

JitGub commented Jan 30, 2017

Maybe a warning can do it.
Like JOSM editor do.

@matkoniecz
Copy link

Rosemary editor

According to https://github.com/sozialhelden/rosemary Rosemary is API client, not editor. Creating a proper editor requires (among others) handling poor/invalid user input.

It looks like the Rosemary editor can create a tag that gives warnings in JOSM editor version 11441.

It did what user instructed it to do, right? It is not a job of API client to run validation rules like that - it should be implemented in editor itself.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants