Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Optimization and Modification for Conversation Configuration Module #86

Open
Mefisto04 opened this issue Oct 19, 2024 · 2 comments

Comments

@Mefisto04
Copy link

The ConversationConfig module located at podcastfy/utils/config_conversation.py requires several optimizations and modifications:

  1. Error Handling:

    • Improve error handling by catching specific exceptions like FileNotFoundError and yaml.YAMLError for clearer error messages.
    • Replace print statements with logging for better output control.
  2. Configuration Loading:

    • Streamline the get_conversation_config_path method by using a loop to check for the configuration file in multiple locations, reducing redundancy.
  3. Deep Copy Logic:

    • Simplify the deep copy logic in the __init__ method by directly updating self.config_conversation with the loaded configuration to enhance clarity.

Please assign me this issue so that i can start work on it.

@souzatharsis
Copy link
Owner

souzatharsis commented Oct 20, 2024 via email

@Mefisto04
Copy link
Author

hey @souzatharsis i have implemented this in the pr #95, please check and review once.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants