Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

notify_master is duplicated on keepalived_vrrp_instance resources #151

Open
john-scalingo opened this issue Mar 7, 2024 · 2 comments
Open

Comments

@john-scalingo
Copy link
Contributor

👻 Brief Description

On vrrp_instances the notify_master script is duplicated.

🥞 Cookbook version

On versions after v4.0.0

Steps To Reproduce

Create an instance:

keepalived_vrrp_instance 'inside_network' do
  master true
  interface node['network']['default_interface']
  virtual_router_id 51
  priority 101
  authentication auth_type: 'PASS', auth_pass: 'secret1'
  virtual_ipaddress %w( 192.168.1.1 )
  notify_master "/tmp/test.sh"
  smtp_alert true
end

And run the cookbook.
The file will contain the notify_master "/tmp/test.sh" line twice.

🚓 Expected behavior

The generated file should contain the following line: notify_master "/tmp/test.sh" only once.

@xorima
Copy link
Contributor

xorima commented Mar 9, 2024

Can you raise a pr to fix this?

@john-scalingo
Copy link
Contributor Author

john-scalingo commented Mar 11, 2024

I would love to. I have the PR ready but i need the approbation of my company for the Developer Certification of Origin. As soon as I have the go from my company I'll open the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants