From 46846a4bafb5664b3fc7ae08e47c415639084c44 Mon Sep 17 00:00:00 2001 From: Juan Cruz Viotti Date: Fri, 7 Jun 2024 13:08:24 -0400 Subject: [PATCH] Re-enable Windows builds on GitHub Actions (#778) Signed-off-by: Juan Cruz Viotti --- .github/workflows/ci.yml | 24 +++++++++++++++--------- 1 file changed, 15 insertions(+), 9 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 5ea913901..e9ca7457f 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -45,15 +45,12 @@ jobs: cxx: g++ type: shared shell: sh - - # TODO: Add back once the SEH sudden exceptions are gone - # See: https://github.com/actions/runner-images/issues/10004 - # - os: windows-latest - # type: static - # shell: pwsh - # - os: windows-latest - # type: shared - # shell: pwsh + - os: windows-latest + type: static + shell: pwsh + - os: windows-latest + type: shared + shell: pwsh # Sanitizers - os: ubuntu-latest @@ -118,6 +115,15 @@ jobs: cmake --install ./build --prefix ./build/dist --config Release --verbose --component sourcemeta_jsontoolkit_dev + - name: Copy in the correct VC runtime DLLs (workaround for actions/runner-images#10004) + if: runner.os == 'windows' + run: | + Copy-Item (Join-Path ` + ((Get-ChildItem -Directory ` + -Path "C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Redist\MSVC\14.*" | + Sort -Descending | Select-Object -First 1).FullName + ) 'x64\Microsoft.VC143.CRT\*.dll') "build\bin\Release" + # Not every CTest version supports the --test-dir option. If such option # is not recognized, `ctest` will successfully exit finding no tests. # Better to be sure and `cd` all the time here.