Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove warnings logged for XYPlot while running the JS test suite #1010

Closed
EshaanAgg opened this issue Mar 4, 2024 · 2 comments
Closed

Remove warnings logged for XYPlot while running the JS test suite #1010

EshaanAgg opened this issue Mar 4, 2024 · 2 comments

Comments

@EshaanAgg
Copy link
Contributor

image
When running the complete JS test suite, the above warning is logged in the console due to using the componentWillReceiveProps lifecycle hook in the XYPlot component. Since we are using this component directly from the react-vis library, we can't update it's implementation. Maybe bumping the version of the library can fix the issue (?)

@PhilippWendler
Copy link
Member

Yes, this is kind of a known issue. It is unclear whether react-vis is still maintained enough such that we can hope for a fix of uber/react-vis#1084 / uber/react-vis#1356.

We have #570 for tracking the question of what to do with react-vis, and I don't think we can anything do about the mentioned warnings besides from waiting for a new version of react-vis or replacing it with something else. So I will close this issue here, but nevertheless bringing up topics like this is appreciated!

@PhilippWendler PhilippWendler changed the title remove warnings logged while running the complete test suite Remove warnings logged for XYPlot while running the JS test suite Mar 5, 2024
@EshaanAgg
Copy link
Contributor Author

Yes sir, sounds good! Thanks for the response and all the background to the issue!

@EshaanAgg EshaanAgg closed this as not planned Won't fix, can't repro, duplicate, stale Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants