Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2.2.3 #492

Merged
merged 3 commits into from
Nov 21, 2024
Merged

v2.2.3 #492

merged 3 commits into from
Nov 21, 2024

Conversation

hoonyworld
Copy link
Member

๐Ÿ‘ฉโ€๐Ÿ’ป Contents

  • v2.2.3

๐Ÿ“ Review Note

๐Ÿ“ฃ Related Issue

  • closed #

โœ… ์ ๊ฒ€์‚ฌํ•ญ

  • docker-compose.yml ํŒŒ์ผ์— ๋งˆ์ด๊ทธ๋ ˆ์ด์…˜ ํ•œ API์˜ ํฌ์›Œ๋”ฉ์„ ๋ณ€๊ฒฝํ•ด์คฌ๋‚˜์š”?
  • Spring Secret ๊ฐ’์„ ์ˆ˜์ •ํ•˜๊ฑฐ๋‚˜ ์ถ”๊ฐ€ํ–ˆ๋‹ค๋ฉด Github Secret์—์„œ ์ˆ˜์ •์„ ํ•ด์คฌ๋‚˜์š”?
  • Nestjs Secret ๊ฐ’์„ ์ˆ˜์ •ํ•˜๊ฑฐ๋‚˜ ์ถ”๊ฐ€ํ–ˆ๋‹ค๋ฉด Docker-Compose.yml ํŒŒ์ผ ๋ฐ ์ธ์Šคํ„ด์Šค ๋‚ด๋ถ€์˜ .env ํŒŒ์ผ์„ ์ˆ˜์ •ํ–ˆ๋‚˜์š”?

mikekks and others added 3 commits November 17, 2024 16:01
* move(external): ์•Œ๋ฆผ ๊ด€๋ จ ๊ธฐ๋Šฅ internal -> external ๋กœ ๋ณ€๊ฒฝ

* chore(Meeting): getMeetingStatusValue ๊ณผ getMeetingStatus ๋ฉ”์„œ๋“œ ๋ถ„๋ฆฌ

* style(PageOptionsDto): ์ฝ”๋“œ ๋ฐฐ์น˜ ์ˆ˜์ •

* chore(SecurityConfig): internal ๊ธฐ๋Šฅ ํ™”์ดํŠธ๋ฆฌ์ŠคํŠธ์— ์ถ”๊ฐ€

* add(Dto): Dto ์ถ”๊ฐ€

* feat(InternalMeetingController): ๋ชจ์ž„ ๋ชฉ๋ก ์กฐํšŒ ์ปจํŠธ๋กค๋Ÿฌ ๊ตฌํ˜„

* feat(InternalMeetingService): ๋ชจ์ž„ ๋ชฉ๋ก ์กฐํšŒ ์„œ๋น„์Šค ๋กœ์ง ๊ตฌํ˜„

* rename(AdvertisementCustomPageable): ๊ธฐ์กด์— ์žˆ๋˜ CustomPageable -> AdvertisementCustomPageable ๋กœ ์ด๋ฆ„ ๋ณ€๊ฒฝ

* feat(CustomPageable): CustomPageable ๊ตฌํ˜„ ๋ฐ ์ ์šฉ

* fix(CustomPageable): take -> size ์ˆ˜์ •

* fix: 3ํ•ญ ์—ฐ์‚ฐ์ž -> if ๋ฌธ์œผ๋กœ ์ˆ˜์ •

* docs(InternalMeetingGetAllMeetingQueryDto): ์Šค์›จ๊ฑฐ ์„ค๋ช… ์ถ”๊ฐ€

* fix(InternalMeetingController): requestBody -> requestParam ๋ณ€๊ฒฝ

* docs(InternalMeetingApi): ์Šค์›จ๊ฑฐ ์ถ”๊ฐ€

* docs(AdvertisementCustomPageable): javadoc ์ถ”๊ฐ€

* chore: getBlockedUsers ๊ธฐ์กด ๋ฉ”์„œ๋“œ ์ˆ˜์ •
* chore: category ํ•„๋“œ ์ถ”๊ฐ€

* chore: joinableParts ์ถ”๊ฐ€
* feat(InternalMeetingStatsController): orgId๋กœ ์ฐธ์—ฌํ•œ ์Šคํ„ฐ๋”” ๊ฐœ์ˆ˜๋ฅผ ๋ฐ˜ํ™˜ํ•˜๋Š” API ๊ตฌํ˜„

* feat(ApprovedStudyCountResponseDto): ํ”Œ๊ทธ id์™€ ์Šน์ธ๋œ ์Šคํ„ฐ๋”” ์ˆ˜๋ฅผ ๋ฐ˜ํ™˜ํ•˜๋Š” DTO ๊ตฌํ˜„

* feat(InternalMeetingStatsService): orgId๋กœ ์Šน์ธ๋œ ์Šคํ„ฐ๋”” ๊ฐœ์ˆ˜ ์กฐํšŒ ๊ธฐ๋Šฅ ์ถ”๊ฐ€

* feat(ApprovedStudyCountProjection): orgId์™€ approvedStudyCount๋ฅผ ๋ฐ˜ํ™˜ํ•˜๋Š” ํ”„๋กœ์ ์…˜ ์ธํ„ฐํŽ˜์ด์Šค ์ž‘์„ฑ

* feat(ApplyRepository): orgId๋ฅผ ๊ธฐ์ค€์œผ๋กœ ์Šน์ธ๋œ ์Šคํ„ฐ๋”” ์ˆ˜ ์กฐํšŒ ์ฟผ๋ฆฌ ๊ตฌํ˜„

* feat(InternalMeetingStatsApi): ์œ ์ €์˜ ์Šน์ธ๋œ ์Šคํ„ฐ๋”” ์ˆ˜ ์กฐํšŒ API ์Šค์›จ๊ฑฐ ๋ช…์„ธ ๊ตฌํ˜„

* chore(ApplyRepository): ์ฃผ์„ ์ œ๊ฑฐ

* refactor: ๋ฐ˜ํ™˜ ๋กœ์ง DTO ๋‚ด๋ถ€๋กœ ์ด๋™

* feat: Transaction ์ฝ๊ธฐ ์†์„ฑ ์ถ”๊ฐ€

* del: ํ”„๋กœ์ ์…˜ ์ธํ„ฐํŽ˜์ด์Šค ์‚ญ์ œ

* refactor(ApprovedStudyCountResponseDto): ์ •์  ํŒฉํ† ๋ฆฌ ๋ฉ”์„œ๋“œ ๋ฆฌํŒฉํ† ๋ง

* refactor(ApplyRepository): JPQL ์ฟผ๋ฆฌ ๋ณ€๊ฒฝ

* refactor(InternalMeetingStatsService): ๋น„์ฆˆ๋‹ˆ์Šค ๋กœ์ง ๋ณ€๊ฒฝ

* refactor(InternalMeetingStatsService): orgId์— ํ•ด๋‹นํ•˜๋Š” ์œ ์ €๊ฐ€ ์—†์„ ๊ฒฝ์šฐ ์Šน์ธ๋œ ์Šคํ„ฐ๋”” ์‹ ์ฒญ ์ˆ˜๋ฅผ 0์œผ๋กœ ๋ฐ˜ํ™˜ํ•˜๋„๋ก ๋ณ€๊ฒฝ

* refactor(InternalMeetingStatsService): ์œ ์ € ๊ฐ์ฒด๋กœ ๋ถ€ํ„ฐ orgId๋ฅผ ๊ฐ€์ ธ์™€์„œ ๋ฐ˜ํ™˜ํ•˜๋„๋ก ๋ฆฌํŒฉํ† ๋ง
Copy link

height bot commented Nov 21, 2024

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

๐Ÿ’กTip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

@hoonyworld hoonyworld merged commit 51dc006 into main Nov 21, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants