Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: 모임 관련 개선 #479

Merged
merged 9 commits into from
Nov 10, 2024
Merged

chore: 모임 관련 개선 #479

merged 9 commits into from
Nov 10, 2024

Conversation

hoonyworld
Copy link
Member

@hoonyworld hoonyworld commented Nov 8, 2024 •
edited
Loading

👩‍💻 Contents

  • 기존 모임 신청 API를 행사 신청 API와 일반 모임 신청 API로 분리했습니다.

📝 Review Note

📣 Related Issue

✅ 점검사항

  • docker-compose.yml 파일에 마이그레이션 한 API의 포워딩을 변경해줬나요?
  • Spring Secret 값을 수정하거나 추가했다면 Github Secret에서 수정을 해줬나요?
  • Nestjs Secret 값을 수정하거나 추가했다면 Docker-Compose.yml 파일 및 인스턴스 내부의 .env 파일을 수정했나요?

@hoonyworld hoonyworld added 🛠️ refactor 리팩토링 및 개선 🧪 test 테스트 코드 관련 작업 labels Nov 8, 2024
@hoonyworld hoonyworld self-assigned this Nov 8, 2024
@hoonyworld hoonyworld linked an issue Nov 8, 2024 that may be closed by this pull request
refactor: 모임 관련 개선 #478
Closed
@height Height
Copy link

height bot commented Nov 8, 2024

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

mikekks
mikekks previously approved these changes Nov 8, 2024
View reviewed changes
Copy link
Member

@mikekks mikekks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

테스트 코드 까지 하셨군요!

고생하셨습니다 ~!!

@mikekks mikekks changed the title refactor: 모임 신청 API를 행사 신청 API와 일반 모임 신청 API로 분리 chore: 모임 관련 개선 Nov 9, 2024
mikekks
mikekks reviewed Nov 10, 2024
View reviewed changes
main/src/main/java/org/sopt/makers/crew/main/global/exception/ErrorStatus.java Outdated
Comment on lines 40 to 41
GENERAL_CATEGORY_NOT_ALLOW_EVENT_MEETING("일반 모임에는 행사 모임 신청이 허용되지 않습니다."),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

해당 에러 추가 말고, 기존에 있는 NOT_IN_APPLY_PERIOD 로 하는건 어떠신가요?!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

제가 뒤늦게 확인했습니다 죄송합니다

NOT_ALLOW_MEETING_APPLY로 포괄적으로 에러메세지를 구성해서 올려놨습니다!

@hoonyworld hoonyworld merged commit c045e95 into develop Nov 10, 2024
1 check passed
@mikekks mikekks deleted the refactor/#478 branch November 10, 2024 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikekks mikekks mikekks approved these changes

Assignees

@hoonyworld hoonyworld

Labels
🛠️ refactor 리팩토링 및 개선 size/L 🧪 test 테스트 코드 관련 작업
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

refactor: 모임 관련 개선
2 participants
@hoonyworld @mikekks