Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v2.1.5 #446

Merged
merged 4 commits into from
Oct 9, 2024
Merged

v2.1.5 #446

merged 4 commits into from
Oct 9, 2024

Conversation

mikekks
Copy link
Member

@mikekks mikekks commented Oct 9, 2024

πŸ‘©β€πŸ’» Contents

  • v2.1.5

πŸ“ Review Note

πŸ“£ Related Issue

  • closed #

βœ… 점검사항

  • docker-compose.yml νŒŒμΌμ— λ§ˆμ΄κ·Έλ ˆμ΄μ…˜ ν•œ API의 ν¬μ›Œλ”©μ„ λ³€κ²½ν•΄μ€¬λ‚˜μš”?
  • Spring Secret 값을 μˆ˜μ •ν•˜κ±°λ‚˜ μΆ”κ°€ν–ˆλ‹€λ©΄ Github Secretμ—μ„œ μˆ˜μ •μ„ ν•΄μ€¬λ‚˜μš”?
  • Nestjs Secret 값을 μˆ˜μ •ν•˜κ±°λ‚˜ μΆ”κ°€ν–ˆλ‹€λ©΄ Docker-Compose.yml 파일 및 μΈμŠ€ν„΄μŠ€ λ‚΄λΆ€μ˜ .env νŒŒμΌμ„ μˆ˜μ •ν–ˆλ‚˜μš”?

hoonyworld and others added 3 commits October 5, 2024 17:08
@hoonyworld
test: μ§€μ›μž/μ°Έμ—¬μž 쑰회 API ν…ŒμŠ€νŠΈ μ½”λ“œ μž‘μ„± (#439)
4534081 
* refactor(AdvertisementGetDto): isSponsoredContent ν•„λ“œ DTOμ—μ„œ 제거

* test(MeetingV2ServiceTest): ν…ŒμŠ€νŠΈ 리뷰λ₯Ό μœ„ν•΄ 쀑간과정 컀밋

* test(MeetingV2ServiceTest): μ½”λ“œ 리뷰 반영

* fix(MeetingV2ServiceTest): λ©”λͺ¨λ¦¬ μœ„μΉ˜κ°€ λ‹€λ₯΄λ”라도, ν•„λ“œ 값이 κ°™μœΌλ©΄ λ™μΌν•œ 객체둜 μΈμ‹ν•˜λ„λ‘ μˆ˜μ •

* test(MeetingV2ServiceTest): 직접 ν•„λ“œλ‚΄μš©μ„ μΆ”μΆœν•΄μ„œ desc μˆœμ„œλŒ€λ‘œ μ‘°νšŒν•œ 결과와 λΉ„κ΅ν•˜λŠ” κΈ°λŠ₯ μΆ”κ°€

* test(MeetingV2ServiceTest): 둜그 제거

* test(MeetingV2ServiceTest): 쓰지 μ•ŠλŠ” ν•„λ“œ 제거

* test(MeetingV2ServiceTest): 필터링 μ‹œ μ œμ™Έλœ μ°Έμ—¬μžμ˜ μ •λ³΄λŠ” κ°€μ Έμ˜€μ§€ μ•ŠλŠ”μ§€ ν™•μΈν•˜κΈ° μœ„ν•œ ν…ŒμŠ€νŠΈ μΆ”κ°€
@mikekks
fix: excel둜 μ—΄μ—ˆμ„ λ•Œ, csv ν•œκΈ€ 깨짐 이슈 ν•΄κ²° (#444)
969e0b1
@mikekks
οΏ½test: λͺ¨μž„μƒμ„Έμ‘°νšŒ 및 λͺ¨μž„μ „μ²΄μ‘°νšŒ ν…ŒμŠ€νŠΈ μ½”λ“œ μž‘μ„± (#441)
00b17ca 
* test(getMeetingById): λͺ¨μž„ 상세 쑰회 ν…ŒμŠ€νŠΈ μ½”λ“œ μž‘μ„±

* test: stubbing μ‹œκ°„ λ³€κ²½ (잘 λ‹«νžˆλŠ”μ§€λ³΄λ‹¨ 잘 μ—΄λ¦¬λŠ”μ§€ ν™•μΈν•˜κΈ° μœ„ν•¨)

* chore: id μ‚­μ œ 및 'μ„Έλ―Έλ‚˜' 데이터 μΆ”κ°€

* fix: 비ꡐ식 '>' κ°€ μ•„λ‹Œ  '>=' λ˜λ„λ‘ 적용

* test: λͺ¨μž„ 전체 쑰회 ν…ŒμŠ€νŠΈ μ½”λ“œ μž‘μ„±

* fix: λͺ¨μ§‘μ „, λͺ¨μ§‘μ™„λ£Œ μƒνƒœ μ˜¬λ°”λ₯΄κ²Œ μΏΌλ¦¬ν•˜λ„λ‘ μˆ˜μ •
@mikekks mikekks added πŸš€ deployment μ •κΈ° 배포와 κ΄€λ ¨λœ 라벨 3️⃣ patch labels Oct 9, 2024
@mikekks mikekks self-assigned this Oct 9, 2024
@height Height
Copy link

height bot commented Oct 9, 2024

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

πŸ’‘Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

@hoonyworld
test: λͺ¨μž„ 지원 μ·¨μ†Œ, λͺ¨μž„ 지원 ν…ŒμŠ€νŠΈ μ½”λ“œ μž‘μ„± (#442)
f6b549b 
* refactor(AdvertisementGetDto): isSponsoredContent ν•„λ“œ DTOμ—μ„œ 제거

* test(MeetingV2ServiceTest): λͺ¨μž„ 지원 μ·¨μ†Œ, λͺ¨μž„ 지원 ν…ŒμŠ€νŠΈ μ½”λ“œ μž‘μ„±

* test(MeetingV2ServiceTest): λ©”μ„œλ“œ μ„€λͺ… λ³€κ²½

* test(MeetingV2ServiceTest): 이미 μ§€μ›ν•œ μ‚¬μš©μž μ˜ˆμ™Έ ν…ŒμŠ€νŠΈ, 지원 κΈ°κ°„ μ „ 지원 μ˜ˆμ™Έ ν…ŒμŠ€νŠΈ μΆ”κ°€

* test(MeetingV2ServiceTest): ν•„μš”ν•˜μ§€ μ•Šμ€ μ½”λ“œ μ‚­μ œ 및 λͺ¨μ§‘ 마감 κΈ°κ°„ λ³€κ²½
@mikekks mikekks merged commit 0fb1894 into main Oct 9, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hoonyworld hoonyworld Awaiting requested review from hoonyworld

Assignees

@mikekks mikekks

Labels
3️⃣ patch πŸš€ deployment μ •κΈ° 배포와 κ΄€λ ¨λœ 라벨 size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mikekks @hoonyworld