Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

db: use Text where length not limited #2292

Closed
wants to merge 1 commit into from
Closed

db: use Text where length not limited #2292

wants to merge 1 commit into from

Conversation

RhinosF1
Copy link
Contributor

@RhinosF1 RhinosF1 commented May 29, 2022 •
edited
Loading

Fixes #2291

Description

What does this do? What problem does it solve? Does it resolve any GitHub issues?

Checklist

  • I have read CONTRIBUTING.md
  • I can and do license this contribution under the EFLv2
  • No issues are reported by make qa (runs make quality and make test)
  • I have tested the functionality of the things this change touches

@RhinosF1
Copy link
Contributor Author

This doesn't work when primary key is TEXT :(

@RhinosF1 RhinosF1 closed this May 29, 2022
@RhinosF1 RhinosF1 deleted the patch-2 branch May 29, 2022 18:36
@dgw
Copy link
Member

dgw commented May 29, 2022

So don't try to make the keys TEXT? If your database keys are over 255 bytes, then you need a therapist 😂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

value.nick_values column isn't long enough
2 participants
@RhinosF1 @dgw