Refresh Tweety instance less often #44
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seems that keeping a Tweety instance around for too long doesn't work. It'll eventually start failing to fetch tweets. Probably some secret involved that's time-derived. Not knowing the "safe" time interval to keep using a single Tweety instance, I have chosen the nuclear option: No optimization at all.
Long-lived instances of tweety.bot.Twitter() eventually fail. Refreshing the cached instance ONCE will solve this, at the cost of unnecessarily refreshing the cached instance if someone posts a private/protected/18+ tweet link.
Examined the Tweety code a bit, found where certain exceptions are raised and adapted to better catch them.
Merged
|
I declare #46 the more important update; dropping this back to draft status with no milestone. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Built on #43, which is the "quick fix" that can be released immediately. Will save this for a future patch release, after much better testing than I can do in one day.
Also reorganizes some error handling. Examining the Tweety code, I found that some cases won't ever happen outside of constructing a new object instance, so those have been encapsulated in a helper.