Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include sample application to enhance pub.dev package #27

Closed
wants to merge 1 commit into from
Closed

Include sample application to enhance pub.dev package #27

wants to merge 1 commit into from

Conversation

marktefftech
Copy link
Collaborator

Purpose of this feature is to enhance the pub.dev package by including a sample application.

Sample app code comes from this sample app:
https://github.com/marktefftech/flutter_okta_sample/tree/develop

Documentation for including the sample:
https://dart.dev/tools/pub/package-layout#examples

@sonikro
Copy link
Owner

sonikro commented Oct 21, 2021

This PR is so big that my Edge just crashed hahaha.
@marktefftech, I think there are many files in this PR that should not be added to git. I think we should have a .gitignore file inside the example project folder, just like any other flutter project. This will decrease the number of files we commit to the repo.

Example of another library's example: https://github.com/fluttercommunity/plus_plugins/tree/main/packages/android_alarm_manager_plus/example

@Perdiga
Copy link
Collaborator

Perdiga commented Oct 21, 2021

Hi @marktefftech, could you please read this article https://dart.dev/guides/libraries/private-files? It will help you to clean some files that are not needed in the PR and it will help us to focus on what needs to be revised.

Thank you for your amazing contribution.

@Perdiga Perdiga added documentation Improvements or additions to documentation enhancement New feature or request labels Oct 21, 2021
@Perdiga Perdiga linked an issue Oct 21, 2021 that may be closed by this pull request
Create an example project inside our plugin #5
Open
@marktefftech
Copy link
Collaborator Author

Hi all I know it has been a while but closing this as it is replaced by PR #29

Tracking as a git submodule will allow to update the repo's independently

@marktefftech marktefftech deleted the feature/include-sample-app branch January 12, 2022 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Perdiga Perdiga Awaiting requested review from Perdiga

@sonikro sonikro Awaiting requested review from sonikro

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create an example project inside our plugin
4 participants
@marktefftech @sonikro @Perdiga @markteffeteller-okta