[Mellanox] When 40G optic is in PLUGGED-ERR state, no amber LED is activated

[maq123]

Setup:

admin@sonic:~$ show version | head
SONiC Software Version: SONiC.HEAD.763-a7701fe
Distribution: Debian 9.5
Kernel: 4.9.0-7-amd64
Build commit: a7701fe
Build date: Mon Oct 15 12:47:09 UTC 2018
Built by: johnar@jenkins-worker-3

Docker images:
REPOSITORY                 TAG                 IMAGE ID            SIZE
docker-orchagent-mlnx      HEAD.763-a7701fe    73031690b2e6        259.7 MB
admin@sonic:~$ show platform summary
Platform: x86_64-mlnx_msn2100-r0
HwSKU: ACS-MSN2100
ASIC: mellanox

Issue:

I observed that once I put 100G optic in the switch which is unsupported it starts blinking with an amber LED to indicate that.
However, with exactly the same situation with 40G optics, the LED is not activated at all.
I think the latter case should start an orange LED as well.

admin@sonic:~$ docker exec -it syncd sx_api_ports_dump.py
=================================================================================================================
|  log_port|local_port|label_port|       mtu| admin_s|  oper_s|       module_s|  pvid|     oper_speed|  fec_mode|
=================================================================================================================
|   0x10100|         1|         7|      9122|      UP|    DOWN|    PLUGGED-ERR|     1|            N/A|      None|
|   0x10500|         5|         8|      9122|      UP|    DOWN|      UNPLUGGED|     1|            N/A|      None|
|   0x10900|         9|         5|      9122|      UP|      UP|        PLUGGED|     1|      100GB_CR4|        RS|
|   0x10d00|        13|         6|      9122|      UP|    DOWN|      UNPLUGGED|     1|            N/A|      None|
|   0x11100|        17|         3|      9122|      UP|    DOWN|        PLUGGED|     1|            N/A|      None|
|   0x11500|        21|         4|      9122|      UP|    DOWN|      UNPLUGGED|     1|            N/A|      None|
|   0x11900|        25|         1|      9122|      UP|    DOWN|        PLUGGED|     1|            N/A|      None|
|   0x11d00|        29|         2|      9122|      UP|    DOWN|      UNPLUGGED|     1|            N/A|      None|
|   0x12100|        33|        10|      9122|      UP|    DOWN|      UNPLUGGED|     1|            N/A|      None|
|   0x12500|        37|         9|      9122|      UP|    DOWN|    PLUGGED-ERR|     1|            N/A|      None|
|   0x12900|        41|        12|      9122|      UP|    DOWN|      UNPLUGGED|     1|            N/A|      None|
|   0x12d00|        45|        11|      9122|      UP|    DOWN|    PLUGGED-ERR|     1|            N/A|      None|
|   0x13100|        49|        14|      9122|      UP|      UP|        PLUGGED|     1|       40GB_CR4|      None|
|   0x13500|        53|        13|      9122|      UP|    DOWN|    PLUGGED-ERR|     1|            N/A|      None|
|   0x13900|        57|        16|      9122|      UP|    DOWN|        PLUGGED|     1|            N/A|      None|
|   0x13d00|        61|        15|      9122|      UP|    DOWN|      UNPLUGGED|     1|            N/A|      None|
=================================================================================================================

Reproduce steps:

Put a non-mellanox optic in the switch. Compare LED behaviour for 100G and 40G types.

[sar2015]

with 40G optics if we have other end point as same optic and same LC-to-LC this should give you link up but we nee to make sure, if the optic is Long haul or Short haul and Single mode cable or multi-mode cable communication between your LEG. I hope this help.